Re: [PATCH]: add debug flag parameter for SCSI tape driver - 2nd request

2014-10-23 Thread Christoph Hellwig
Thanks, I've applied this patch to the core-for-3.19 branch after fixing a few whitespace issues. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH]: add debug flag parameter for SCSI tape driver - 2nd request

2014-10-19 Thread Kai Mäkisara (Kolumbus)
> On 19.10.2014, at 16.44, Laurence Oberman wrote: > > Hello Kai > > Thanks. > > Here is v3 > > This patch adds a debug_flag parameter that can be set on module load, and > allows the DEBUG facility without a module recompile. > Note that now DEBUG 1 is the default with this patch. > > Usa

Re: [PATCH]: add debug flag parameter for SCSI tape driver - 2nd request

2014-10-19 Thread Laurence Oberman
pr_err("Unable register sysfs class for SCSI tapes\n"); - Original Message - From: "Kai Mäkisara (Kolumbus)" To: "Laurence Oberman" Cc: "Rob Evers" , linux-scsi@vger.kernel.org Sent: Sunday, October 19, 2014 4:54:10 AM Subject: Re: [PATC

Re: [PATCH]: add debug flag parameter for SCSI tape driver - 2nd request

2014-10-19 Thread Kai Mäkisara (Kolumbus)
Hello, I am responding to this, but noticed your next, fixed version. > On 17.10.2014, at 23.20, Laurence Oberman wrote: > > Hello Kai > > You have seen this patch before. The first time around, given that we don't > enable DEBUG by default, I let it go. > However we have been looking into de

Re: [PATCH]: add debug flag parameter for SCSI tape driver - 2nd request

2014-10-17 Thread Laurence Oberman
"Laurence Oberman" To: "Kai Mäkisara (Kolumbus)" , "Rob Evers" Cc: linux-scsi@vger.kernel.org Sent: Friday, October 17, 2014 4:20:29 PM Subject: Re: [PATCH]: add debug flag parameter for SCSI tape driver - 2nd request Hello Kai You have seen this patch before. The

Re: [PATCH]: add debug flag parameter for SCSI tape driver - 2nd request

2014-10-17 Thread Laurence Oberman
Hello Kai You have seen this patch before. The first time around, given that we don't enable DEBUG by default, I let it go. However we have been looking into defining DEBUG 1 by default here at Redhat and then setting the default to disabled. Are you open to considering changing the driver base

Re: Debug flag parameter for SCSI tape driver

2014-06-13 Thread Dale R. Worley
Are ANSI-formatted tapes used on Linux? That is, tapes that contain multiple files and use the the ANSI (= ECMA-13) tape labels. My uderstanding is that a lot of the modern cartridge tapes record only fixed-length blocks and/or that is how they are always used these days. Dale -- To unsubscribe

Re: [PATCH]: add debug flag parameter for SCSI tape driver

2014-06-11 Thread Laurence Oberman
, June 11, 2014 2:24:25 PM Subject: Re: [PATCH]: add debug flag parameter for SCSI tape driver Kai, Thank you for considering this. With #define DEBUG 0 We still include #define DEB(a) #define DEBC(a) With the debug_flag we then provide the needed debug I am looking for at module load time.

Re: [PATCH]: add debug flag parameter for SCSI tape driver

2014-06-11 Thread Dale R. Worley
This thread leads me to ask: Do people use ANSI-formatted tapes any more? That is, tape volumes with miltiple files, header and trailer labels, etc.? Dale -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH]: add debug flag parameter for SCSI tape driver

2014-06-11 Thread Laurence Oberman
i Mäkisara (Kolumbus)" To: "Laurence Oberman" Cc: linux-scsi@vger.kernel.org Sent: Wednesday, June 11, 2014 2:03:15 PM Subject: Re: [PATCH]: add debug flag parameter for SCSI tape driver On 11.6.2014, at 2.48, Laurence Oberman wrote: > Hello > > Take 2 of this pat

Re: [PATCH]: add debug flag parameter for SCSI tape driver

2014-06-11 Thread Kai Mäkisara (Kolumbus)
On 11.6.2014, at 2.48, Laurence Oberman wrote: > Hello > > Take 2 of this patch, changed module description and subject line. > > This patch adds a debug_flag parameter that can be set on module load, and > allows the DEBUG facility without a module recompile. > Usage: mpdprobe st debug_flag=

[PATCH]: add debug flag parameter for SCSI tape driver

2014-06-10 Thread Laurence Oberman
Hello Take 2 of this patch, changed module description and subject line. This patch adds a debug_flag parameter that can be set on module load, and allows the DEBUG facility without a module recompile. Usage: mpdprobe st debug_flag=1 Signed-off-by: Laurence Oberman diff -Nur a/st.c b/st.c ---

Debug flag parameter for SCSI tape driver

2014-06-10 Thread Laurence Oberman
Hello I am tired of building modules to enable SCSI tape driver debug so I am hoping this patch is acceptable. Tested using kernel 3.14.6 Usage example: modprobe st debug_flag=1 diff -Nur a/st.c b/st.c --- a/st.c 2014-06-10 16:45:18.522354105 -0400 +++ b/st.c 2014-06-10 16:45:33.95376