Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-12-06 Thread Martin K. Petersen
John, > "DIX is supported in mpt3sas , but not by default and hence while > loading mpt3sas driver set module parameter "prot_mask=0x7F" to enable > DIX support. " The plumbing is there but it doesn't work. I tried earlier today and I still can't get a single I/O to complete. I'll try to hack a

Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-12-06 Thread John Garry
On 06/12/2018 04:22, Martin K. Petersen wrote: Hi Martin, John, I'll have to go revisit the archives for your exact fio bits. Your fio test case ran to completion on all my test systems. But I successfully ran our DIX/T10 PI qualification tooling without any errors on the latest SCSI t

Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-12-05 Thread Martin K. Petersen
John, >> I'll have to go revisit the archives for your exact fio bits. Your fio test case ran to completion on all my test systems. >> But I successfully ran our DIX/T10 PI qualification tooling without any >> errors on the latest SCSI tree. On both scsi_debug and FC hardware. > > I'm not fimi

Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-12-05 Thread John Garry
On 05/12/2018 02:22, Martin K. Petersen wrote: Hi Martin, John, OK, great. Happy to help. So far we have hisi_sas fio issue to go on plus knowledge that this issue seems to be exposed/triggered by enabling SCSI MQ. I'll have to go revisit the archives for your exact fio bits. But I succ

Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-12-04 Thread Martin K. Petersen
Ming, > For DIX/DIF test, I think you need to pass 'dev_size_mb=XXX' instead of > 'virtual_gb'. Correct! -- Martin K. Petersen Oracle Linux Engineering

Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-12-04 Thread Martin K. Petersen
John, > OK, great. Happy to help. So far we have hisi_sas fio issue to go on > plus knowledge that this issue seems to be exposed/triggered by > enabling SCSI MQ. I'll have to go revisit the archives for your exact fio bits. But I successfully ran our DIX/T10 PI qualification tooling without a

Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-12-03 Thread Martin K. Petersen
Hi John, > We have also noticed that if we just enable DIF in hisi_sas (with MQ), > and not DIX, then no issue. Enabling DIF doesn't really do anything on the kernel side other than setting PROTECT=1 in the READ/WRITE CDB and telling the driver which DIX protection operation the HBA should use.

Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-11-30 Thread John Garry
+ On 30/11/2018 01:19, Ming Lei wrote: On Wed, Nov 28, 2018 at 10:50:11AM +0800, chenxiang (M) wrote: Hi Lei Ming, 在 2018/11/27 21:08, Ming Lei 写道: On Tue, Nov 27, 2018 at 05:55:45PM +0800, chenxiang (M) wrote: Hi all, There is a issue which may be related to CONFIG_SCSI_MQ_DEFAULT: before

Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-11-29 Thread Ming Lei
On Wed, Nov 28, 2018 at 10:50:11AM +0800, chenxiang (M) wrote: > Hi Lei Ming, > > 在 2018/11/27 21:08, Ming Lei 写道: > > On Tue, Nov 27, 2018 at 05:55:45PM +0800, chenxiang (M) wrote: > > > Hi all, > > > > > > There is a issue which may be related to CONFIG_SCSI_MQ_DEFAULT: before we > > > develop

Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-11-29 Thread Ming Lei
On Wed, Nov 28, 2018 at 11:37:23AM +0800, chenxiang (M) wrote: > Hi Lei Ming, > > 在 2018/11/27 21:08, Ming Lei 写道: > > On Tue, Nov 27, 2018 at 05:55:45PM +0800, chenxiang (M) wrote: > > > Hi all, > > > > > > There is a issue which may be related to CONFIG_SCSI_MQ_DEFAULT: before we > > > develope

Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-11-28 Thread Ming Lei
On Wed, Nov 28, 2018 at 10:50:11AM +0800, chenxiang (M) wrote: > Hi Lei Ming, > > 在 2018/11/27 21:08, Ming Lei 写道: > > On Tue, Nov 27, 2018 at 05:55:45PM +0800, chenxiang (M) wrote: > > > Hi all, > > > > > > There is a issue which may be related to CONFIG_SCSI_MQ_DEFAULT: before we > > > develop

Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-11-27 Thread chenxiang (M)
Hi Lei Ming, 在 2018/11/27 21:08, Ming Lei 写道: On Tue, Nov 27, 2018 at 05:55:45PM +0800, chenxiang (M) wrote: Hi all, There is a issue which may be related to CONFIG_SCSI_MQ_DEFAULT: before we developed DIF/DIX feature on kernel 4.18 (disable CONFIG_SCSI_MQ_DEFAULT default), and it works well.

Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-11-27 Thread chenxiang (M)
Hi, 在 2018/11/28 4:22, Ewan D. Milne 写道: On Tue, 2018-11-27 at 17:55 +0800, chenxiang (M) wrote: [ 629.210506] Unable to handle kernel paging request at virtual address 8027e048 [ 629.210506] Unable to handle kernel paging request at virtual address 8027e048 ... [ 629.380218]

Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-11-27 Thread Ewan D. Milne
On Tue, 2018-11-27 at 17:55 +0800, chenxiang (M) wrote: > [ 629.210506] Unable to handle kernel paging request at virtual address > 8027e048 > [ 629.210506] Unable to handle kernel paging request at virtual address > 8027e048 > ... > [ 629.380218] pc : deadline_remove_request+0

Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-11-27 Thread Ming Lei
On Tue, Nov 27, 2018 at 05:55:45PM +0800, chenxiang (M) wrote: > Hi all, > > There is a issue which may be related to CONFIG_SCSI_MQ_DEFAULT: before we > developed DIF/DIX feature on kernel 4.18 (disable CONFIG_SCSI_MQ_DEFAULT > default), and > it works well. I guess you are testing hisi_sas_v3_h

DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT

2018-11-27 Thread chenxiang (M)
Hi all, There is a issue which may be related to CONFIG_SCSI_MQ_DEFAULT: before we developed DIF/DIX feature on kernel 4.18 (disable CONFIG_SCSI_MQ_DEFAULT default), and it works well. But when we switch to kernel 4.19-rc1 and 4.20-rc1, Call trace as follow occurs when running fio and if disab