Re: Crash on WRITE SAME

2014-07-03 Thread Sagi Grimberg
On 7/2/2014 9:36 PM, Christoph Hellwig wrote: On Wed, Jul 02, 2014 at 02:29:05PM -0400, Mikulas Patocka wrote: And what about protection information for commands that transfer partial sectors? (for example, UMAP transfers 24 bytes). Should scsi_transfer_length return 24 or 32 in this case? As f

Re: Crash on WRITE SAME

2014-07-02 Thread Christoph Hellwig
On Wed, Jul 02, 2014 at 02:29:05PM -0400, Mikulas Patocka wrote: > And what about protection information for commands that transfer partial > sectors? (for example, UMAP transfers 24 bytes). Should > scsi_transfer_length return 24 or 32 in this case? As far as I understand so far PI is only defi

Re: Crash on WRITE SAME

2014-07-02 Thread Mikulas Patocka
On Wed, 2 Jul 2014, Christoph Hellwig wrote: > On Wed, Jul 02, 2014 at 02:05:14PM -0400, Mikulas Patocka wrote: > > Hi Sagi > > > > Your commit d77e65350f2d82dfa0557707d505711f5a43c8fd causes crash on SCSI > > WRITE SAME command (it can be triggered by issuing the BLKZEROOUT ioctl). > > The c

Re: Crash on WRITE SAME

2014-07-02 Thread Christoph Hellwig
On Wed, Jul 02, 2014 at 02:05:14PM -0400, Mikulas Patocka wrote: > Hi Sagi > > Your commit d77e65350f2d82dfa0557707d505711f5a43c8fd causes crash on SCSI > WRITE SAME command (it can be triggered by issuing the BLKZEROOUT ioctl). > The crash happens in iscsi_tcp_segment_done because sg_next retur

Crash on WRITE SAME

2014-07-02 Thread Mikulas Patocka
Hi Sagi Your commit d77e65350f2d82dfa0557707d505711f5a43c8fd causes crash on SCSI WRITE SAME command (it can be triggered by issuing the BLKZEROOUT ioctl). The crash happens in iscsi_tcp_segment_done because sg_next returns NULL. Before that commit, there was this code in iscsi_prep_scsi_cmd_pd