On Thu, 24 May 2007 23:15:56 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Kristen Carlson Accardi wrote:
> > Check to see if an ATAPI device supports Asynchronous Notification.
> > If so, enable it.
> >
> > Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
> > ---
> > Andrew, I cleaned
Kristen Carlson Accardi wrote:
Check to see if an ATAPI device supports Asynchronous Notification.
If so, enable it.
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
---
Andrew, I cleaned up the function header to properly comply with kernel
doc requirements. Other than that, this pat
Check to see if an ATAPI device supports Asynchronous Notification.
If so, enable it.
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
---
Andrew, I cleaned up the function header to properly comply with kernel
doc requirements. Other than that, this patch is the same.
Index: 2.6-mm/
On Wed, 9 May 2007 22:09:52 -0700 Andrew Morton wrote:
> On Wed, 9 May 2007 16:38:09 -0700 Kristen Carlson Accardi <[EMAIL PROTECTED]>
> wrote:
>
> > /**
> > + * ata_dev_set_AN - Issue SET FEATURES - SATA FEATURES
> > + * with sector count set to indicate
> > + *
On Thu, 10 May 2007 01:14:38 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Andrew Morton wrote:
> >> + *@dev: Device to which command will be sent
> >> + *
> >> + *Issue SET FEATURES - SATA FEATURES command to device @dev
> >> + *on port @ap.
> >> + *
> >> + *LOCKI
Andrew Morton wrote:
+ * @dev: Device to which command will be sent
+ *
+ * Issue SET FEATURES - SATA FEATURES command to device @dev
+ * on port @ap.
+ *
+ * LOCKING:
+ * PCI/etc. bus probe sem.
+ *
+ * RETURNS:
+ * 0 on success, AC_ERR_* mask otherwise.
+ */
ooh, l
On Wed, 9 May 2007 16:38:09 -0700 Kristen Carlson Accardi <[EMAIL PROTECTED]>
wrote:
> /**
> + * ata_dev_set_AN - Issue SET FEATURES - SATA FEATURES
> + * with sector count set to indicate
> + * Asynchronous Notification feature
I think kenreldoc re
Check to see if an ATAPI device supports Asynchronous Notification.
If so, enable it.
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
Index: 2.6-git/drivers/ata/libata-core.c
===
--- 2.6-git.orig/drivers/ata/libata-core.c
Check to see if an ATAPI device supports Asynchronous Notification.
If so, enable it.
Changes from last version:
* use parens around id in ata.h
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
Index: 2.6-git/drivers/ata/libata-core.c
===
Kristen Carlson Accardi wrote:
> On Wed, 25 Apr 2007 20:16:51 +0100
> Matt Sealey <[EMAIL PROTECTED]> wrote:
>
>>> +#define ata_id_has_AN(id) \
>>> + ( (((id)[76] != 0x) && ((id)[76] != 0x)) && \
>>> + ((id)[78] & (1 << 5)) )
>> ??
>>
>>> --- 2.6-git.orig/include/linux/libata.h
>>
On Wed, Apr 25, 2007 at 08:16:51PM +0100, Matt Sealey wrote:
> > +#define ata_id_has_AN(id) \
> > + ( (((id)[76] != 0x) && ((id)[76] != 0x)) && \
> > + ((id)[78] & (1 << 5)) )
>
> ??
>
> > --- 2.6-git.orig/include/linux/libata.h
> > +++ 2.6-git/include/linux/libata.h
> > @@ -136,6
On Wed, 25 Apr 2007 20:16:51 +0100
Matt Sealey <[EMAIL PROTECTED]> wrote:
> > +#define ata_id_has_AN(id) \
> > + ( (((id)[76] != 0x) && ((id)[76] != 0x)) && \
> > + ((id)[78] & (1 << 5)) )
>
> ??
>
> > --- 2.6-git.orig/include/linux/libata.h
> > +++ 2.6-git/include/linux/libata.h
Kristen Carlson Accardi wrote:
> Check to see if an ATAPI device supports Asynchronous Notification.
> If so, enable it.
>
> Changes from last version:
> * use parens around id in ata.h
>
> Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
>
> Index: 2.6-git/drivers/ata/libata-core.c
>
Check to see if an ATAPI device supports Asynchronous Notification.
If so, enable it.
Changes from last version:
* use parens around id in ata.h
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
Index: 2.6-git/drivers/ata/libata-core.c
===
On Wed, 25 Apr 2007 02:49:46 +0200
Olivier Galibert <[EMAIL PROTECTED]> wrote:
> On Tue, Apr 24, 2007 at 01:53:27PM -0700, Kristen Carlson Accardi wrote:
> > Check to see if an ATAPI device supports Asynchronous Notification.
> > If so, enable it.
> >
> > changes from last version:
> > * fix typ
On Tue, Apr 24, 2007 at 01:53:27PM -0700, Kristen Carlson Accardi wrote:
> Check to see if an ATAPI device supports Asynchronous Notification.
> If so, enable it.
>
> changes from last version:
> * fix typo in ata_id_has_AN and make word 76 test more clear
> * If we fail to set the AN feature, ju
Check to see if an ATAPI device supports Asynchronous Notification.
If so, enable it.
changes from last version:
* fix typo in ata_id_has_AN and make word 76 test more clear
* If we fail to set the AN feature, just print a warning and continue
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROT
On Tue, 24 Apr 2007 20:05:52 +0200
Olivier Galibert <[EMAIL PROTECTED]> wrote:
> On Tue, Apr 24, 2007 at 08:49:04AM -0700, Kristen Carlson Accardi wrote:
> > On Tue, 24 Apr 2007 12:23:04 +0200
> > Olivier Galibert <[EMAIL PROTECTED]> wrote:
> >
> > > Sorry for replying to Alan's reply, I missed t
On Tue, Apr 24, 2007 at 08:49:04AM -0700, Kristen Carlson Accardi wrote:
> On Tue, 24 Apr 2007 12:23:04 +0200
> Olivier Galibert <[EMAIL PROTECTED]> wrote:
>
> > Sorry for replying to Alan's reply, I missed the original mail.
> >
> > > > +#define ata_id_has_AN(id) \
> > > > + ((id[76]
On Tue, 24 Apr 2007 12:23:04 +0200
Olivier Galibert <[EMAIL PROTECTED]> wrote:
> Sorry for replying to Alan's reply, I missed the original mail.
>
> > > +#define ata_id_has_AN(id)\
> > > + ((id[76] && (~id[76])) & ((id)[78] & (1 << 5)))
>
> (a && ~a) & (b & 32)
>
> I don't think that do
On Tue, 24 Apr 2007 17:03:29 +0900
Tejun Heo <[EMAIL PROTECTED]> wrote:
> Hello,
>
> Kristen Carlson Accardi wrote:
> > static unsigned int ata_print_id = 1;
> > @@ -1744,6 +1745,23 @@ int ata_dev_configure(struct ata_device
> > }
> > dev->cdb_len = (unsigned int) rc;
>
Sorry for replying to Alan's reply, I missed the original mail.
> > +#define ata_id_has_AN(id) \
> > + ((id[76] && (~id[76])) & ((id)[78] & (1 << 5)))
(a && ~a) & (b & 32)
I don't think that does what you think it does, because at that point
it's a funny way to write 0 ((0 or 1) binary-and (0
> + /*
> + * check to see if this ATAPI device supports
> + * Asynchronous Notification
> + */
> + if ((ap->flags & ATA_FLAG_AN) && ata_id_has_AN(id))
> + {
Bracketing police ^^^
> + /* issue SET featur
Hello,
Kristen Carlson Accardi wrote:
> static unsigned int ata_print_id = 1;
> @@ -1744,6 +1745,23 @@ int ata_dev_configure(struct ata_device
> }
> dev->cdb_len = (unsigned int) rc;
>
> + /*
> + * check to see if this ATAPI device supports
Check to see if an ATAPI device supports Asynchronous Notification.
If so, enable it.
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
Index: 2.6-git/drivers/ata/libata-core.c
===
--- 2.6-git.orig/drivers/ata/libata-core.c
25 matches
Mail list logo
