On Mon, 2005-03-07 at 09:21 +0100, Gerd Knorr wrote:
> Probably historical reasons, I havn't tracked the scsi layer changes for
> quite some time, so this might simply be a 2.6 cleanup I've missed
> because of that. Will check ...
OK, Thanks.
> > ch_ioctl() (and the compat): since this is a new
On Sun, Mar 06, 2005 at 07:55:25PM +0200, James Bottomley wrote:
> Looking through this, the only things I really noticed that need work
> are:
>
> ch_do_scsi(): It looks like this has an effective reimplementation of
> scsi_wait_req. We're trying to deprecate the usage of scsi_do_req so we
> ca
Looking through this, the only things I really noticed that need work
are:
ch_do_scsi(): It looks like this has an effective reimplementation of
scsi_wait_req. We're trying to deprecate the usage of scsi_do_req so we
can make it private eventually. What's the reason you can't use
scsi_wait_req?
> > +#include
> not needed.
> > +#include
> I doubt you'll need this one.
Dropped.
> > +#define MAJOR_NR SCSI_CHANGER_MAJOR
> please kill this one
Done.
> > +#include "scsi.h"
> never use this header but always the
Done.
> > +MODULE_SUPPORTED_DEVICE("sch");
> no needed thsese days
Dropp
[this should go to linux-scsi]
> +#include
not needed.
> +#include
I doubt you'll need this one.
> +#include
> +
> +#include /* here are all the ioctls */
should always go before
> +#define MAJOR_NR SCSI_CHANGER_MAJOR
please kill this one
> +#include "scsi.h"
5 matches
Mail list logo
