Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread Boaz Harrosh
On 01/30/2013 09:06 AM, Dan Carpenter wrote: > There wasn't any error handling for this kzalloc(). > ACK-by: Boaz Harrosh James please queue for inclusion > Signed-off-by: Dan Carpenter Thanks Dan > > diff --git a/drivers/scsi/osd/osd_initiator.c > b/drivers/scsi/osd/osd_initiator.c > ind

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread Boaz Harrosh
On 01/30/2013 04:34 PM, walter harms wrote: > <> > I start to see the complexity of the situation. Would you mind to add > the comment "it can be anything. UTF-8 is more likely but not guaranteed > either" ? > For now using a pascal-string seems the best solution but it should be warned > that g

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread walter harms
Am 30.01.2013 14:40, schrieb Benny Halevy: > On Wed, Jan 30, 2013 at 3:00 PM, walter harms wrote: >> >> >> Am 30.01.2013 10:51, schrieb Benny Halevy: >>> On Wed, Jan 30, 2013 at 10:57 AM, walter harms wrote: Am 30.01.2013 09:27, schrieb Dan Carpenter: > On Wed, Jan 30, 2013 a

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread Benny Halevy
On Wed, Jan 30, 2013 at 3:00 PM, walter harms wrote: > > > Am 30.01.2013 10:51, schrieb Benny Halevy: >> On Wed, Jan 30, 2013 at 10:57 AM, walter harms wrote: >>> >>> >>> Am 30.01.2013 09:27, schrieb Dan Carpenter: On Wed, Jan 30, 2013 at 09:15:43AM +0100, walter harms wrote: > > >>>

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread walter harms
Am 30.01.2013 10:51, schrieb Benny Halevy: > On Wed, Jan 30, 2013 at 10:57 AM, walter harms wrote: >> >> >> Am 30.01.2013 09:27, schrieb Dan Carpenter: >>> On Wed, Jan 30, 2013 at 09:15:43AM +0100, walter harms wrote: Am 30.01.2013 08:06, schrieb Dan Carpenter: > There wasn't

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread Benny Halevy
On Wed, Jan 30, 2013 at 9:06 AM, Dan Carpenter wrote: > There wasn't any error handling for this kzalloc(). > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/scsi/osd/osd_initiator.c > b/drivers/scsi/osd/osd_initiator.c > index c06b8e5..d8293f2 100644 > --- a/drivers/scsi/osd/osd_initiat

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread Benny Halevy
On Wed, Jan 30, 2013 at 10:57 AM, walter harms wrote: > > > Am 30.01.2013 09:27, schrieb Dan Carpenter: >> On Wed, Jan 30, 2013 at 09:15:43AM +0100, walter harms wrote: >>> >>> >>> Am 30.01.2013 08:06, schrieb Dan Carpenter: There wasn't any error handling for this kzalloc(). Signed

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread walter harms
Am 30.01.2013 09:27, schrieb Dan Carpenter: > On Wed, Jan 30, 2013 at 09:15:43AM +0100, walter harms wrote: >> >> >> Am 30.01.2013 08:06, schrieb Dan Carpenter: >>> There wasn't any error handling for this kzalloc(). >>> >>> Signed-off-by: Dan Carpenter >>> >>> diff --git a/drivers/scsi/osd/osd_

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread Dan Carpenter
On Wed, Jan 30, 2013 at 09:15:43AM +0100, walter harms wrote: > > > Am 30.01.2013 08:06, schrieb Dan Carpenter: > > There wasn't any error handling for this kzalloc(). > > > > Signed-off-by: Dan Carpenter > > > > diff --git a/drivers/scsi/osd/osd_initiator.c > > b/drivers/scsi/osd/osd_initiat

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread walter harms
Am 30.01.2013 08:06, schrieb Dan Carpenter: > There wasn't any error handling for this kzalloc(). > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/scsi/osd/osd_initiator.c > b/drivers/scsi/osd/osd_initiator.c > index c06b8e5..d8293f2 100644 > --- a/drivers/scsi/osd/osd_initiator.c >

[patch] [SCSI] libosd: check for kzalloc() failure

2013-01-29 Thread Dan Carpenter
There wasn't any error handling for this kzalloc(). Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c index c06b8e5..d8293f2 100644 --- a/drivers/scsi/osd/osd_initiator.c +++ b/drivers/scsi/osd/osd_initiator.c @@ -144,6 +144,10 @@ stati