Re: [patch] [SCSI] atp870u: 64 bit bug in probe()

2015-07-29 Thread Hannes Reinecke
On 07/29/2015 11:36 PM, Dan Carpenter wrote: > On 64 bit CPUs there is a memory corruption bug on probe(). It should > be a u32 pointer instead of an unsigned long pointer or we write past > the end of the setupdata[] array. > > Signed-off-by: Dan Carpenter > --- > Someone reported in 2003 that

[patch] [SCSI] atp870u: 64 bit bug in probe()

2015-07-29 Thread Dan Carpenter
On 64 bit CPUs there is a memory corruption bug on probe(). It should be a u32 pointer instead of an unsigned long pointer or we write past the end of the setupdata[] array. Signed-off-by: Dan Carpenter --- Someone reported in 2003 that probe has a NULL deref so maybe it's related to this memory

[patch] [SCSI] atp870u: 64 bit bug in probe()

2013-09-04 Thread Dan Carpenter
On 64 bit CPUs there is a memory corruption bug on probe(). It should be setting 32 bits of data on both 32 and 64 bit. Signed-off-by: Dan Carpenter --- Static checker stuff. I can't test this. diff --git a/drivers/scsi/atp870u.c b/drivers/scsi/atp870u.c index 15a629d..3edbf30 100644 --- a/dri