Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-18 Thread Juergen Gross
On 08/17/2014 04:38 AM, Nicholas A. Bellinger wrote: On Thu, 2014-08-14 at 12:14 +0200, Juergen Gross wrote: On 08/14/2014 10:53 AM, Juergen Gross wrote: Nicholas, just one more question (see below): On 08/12/2014 11:13 PM, Nicholas A. Bellinger wrote: Hi Juergen & Co, Finally had a chance

Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-16 Thread Nicholas A. Bellinger
On Thu, 2014-08-14 at 12:14 +0200, Juergen Gross wrote: > On 08/14/2014 10:53 AM, Juergen Gross wrote: > > Nicholas, > > > > just one more question (see below): > > > > On 08/12/2014 11:13 PM, Nicholas A. Bellinger wrote: > >> Hi Juergen & Co, > >> > >> Finally had a chance to review this code. Co

Re: Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-16 Thread Nicholas A. Bellinger
On Thu, 2014-08-14 at 06:34 +0200, Juergen Gross wrote: > On 08/13/2014 09:02 AM, Juergen Gross wrote: > > On 08/12/2014 11:13 PM, Nicholas A. Bellinger wrote: > >> Hi Juergen & Co, > >> > >> Finally had a chance to review this code. Comments are inline below.. > > >>> +static struct se_node_acl

Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-14 Thread Juergen Gross
On 08/14/2014 10:53 AM, Juergen Gross wrote: Nicholas, just one more question (see below): On 08/12/2014 11:13 PM, Nicholas A. Bellinger wrote: Hi Juergen & Co, Finally had a chance to review this code. Comments are inline below.. On Fri, 2014-08-08 at 09:49 +0200, jgr...@suse.com wrote:

Re: Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-14 Thread Juergen Gross
Nicholas, just one more question (see below): On 08/12/2014 11:13 PM, Nicholas A. Bellinger wrote: Hi Juergen & Co, Finally had a chance to review this code. Comments are inline below.. On Fri, 2014-08-08 at 09:49 +0200, jgr...@suse.com wrote: ... + if (IS_ERR(tv_nexus->tvn_se_sess

Re: Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-13 Thread Juergen Gross
On 08/13/2014 09:02 AM, Juergen Gross wrote: On 08/12/2014 11:13 PM, Nicholas A. Bellinger wrote: Hi Juergen & Co, Finally had a chance to review this code. Comments are inline below.. +static struct se_node_acl * +scsiback_alloc_fabric_acl(struct se_portal_group *se_tpg) +{ +struct scs

Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-12 Thread Juergen Gross
On 08/12/2014 02:29 PM, Juergen Gross wrote: On 08/11/2014 08:14 PM, Christoph Hellwig wrote: +static void scsiback_notify_work(struct vscsibk_info *info) +{ +info->waiting_reqs = 1; +wake_up(&info->wq); +} + +static irqreturn_t scsiback_intr(int irq, void *dev_id) +{ +scsiback_notif

Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-12 Thread Juergen Gross
On 08/11/2014 08:14 PM, Christoph Hellwig wrote: +#include __scsi_print_sense() +#include struct scsi_sense_hdr +#include SG_ALL What do you need these for? Normally target drivers shouldn't need these. +struct vscsibk_emulate { + void (*pre_function)(struct vscsibk_pend