Re: [VERY EARLY RFC 00/13] Rework SCSI results handling

2018-04-20 Thread Martin K. Petersen
Johannes, > here's a early preview of my SCSI results rework so we can eventually > discuss things next week at LSF/MM (it still has compiler errors on > aic7xxx and scsi_debug). Here's what I'd like to see: - Forget about cramming everything into that dreaded u32 result. Bart's suggestion

Re: [VERY EARLY RFC 00/13] Rework SCSI results handling

2018-04-19 Thread Bart Van Assche
On Thu, 2018-04-19 at 10:10 +0200, Johannes Thumshirn wrote: > On Wed, Apr 18, 2018 at 04:00:43PM +, Bart Van Assche wrote: > > Thank you for having come up with this so quickly. Something I do not > > like about this patch series is that several new very short helper functions > > are introduc

Re: [VERY EARLY RFC 00/13] Rework SCSI results handling

2018-04-19 Thread Hannes Reinecke
On Thu, 19 Apr 2018 10:10:41 +0200 Johannes Thumshirn wrote: > On Wed, Apr 18, 2018 at 04:00:43PM +, Bart Van Assche wrote: > > Thank you for having come up with this so quickly. Something I do > > not like about this patch series is that several new very short > > helper functions are introd

Re: [VERY EARLY RFC 00/13] Rework SCSI results handling

2018-04-19 Thread Johannes Thumshirn
On Wed, Apr 18, 2018 at 04:00:43PM +, Bart Van Assche wrote: > Thank you for having come up with this so quickly. Something I do not > like about this patch series is that several new very short helper functions > are introduced, e.g. set_scsi_result(), clear_scsi_result(), to_scsi_result() > a

Re: [VERY EARLY RFC 00/13] Rework SCSI results handling

2018-04-18 Thread Douglas Gilbert
On 2018-04-18 11:01 AM, Johannes Thumshirn wrote: Hey all, here's a early preview of my SCSI results rework so we can eventually discuss things next week at LSF/MM (it still has compiler errors on aic7xxx and scsi_debug). The motivation behing this is that some drivers have failed to set the sc

Re: [VERY EARLY RFC 00/13] Rework SCSI results handling

2018-04-18 Thread Bart Van Assche
On Wed, 2018-04-18 at 17:01 +0200, Johannes Thumshirn wrote: > here's a early preview of my SCSI results rework so we can eventually > discuss things next week at LSF/MM (it still has compiler errors on > aic7xxx and scsi_debug). > > The motivation behing this is that some drivers have failed to s

[VERY EARLY RFC 00/13] Rework SCSI results handling

2018-04-18 Thread Johannes Thumshirn
Hey all, here's a early preview of my SCSI results rework so we can eventually discuss things next week at LSF/MM (it still has compiler errors on aic7xxx and scsi_debug). The motivation behing this is that some drivers have failed to set the scsi_cmnd::result bytes correctly in the past and this