Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-05 Thread Ben Hutchings
On Wed, 2012-09-05 at 22:56 +0530, Naresh Kumar Inna wrote: > On 9/5/2012 10:01 PM, Stephen Hemminger wrote: > > On Wed, 5 Sep 2012 18:03:59 +0530 > > Naresh Kumar Inna wrote: > > > >> +#define CSIO_ROUNDUP(__v, __r)(((__v) + (__r) - 1) / (__r)) > > > > This is similar to existing r

Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-05 Thread Naresh Kumar Inna
On 9/5/2012 10:03 PM, Stephen Hemminger wrote: > On Wed, 5 Sep 2012 18:03:59 +0530 > Naresh Kumar Inna wrote: > >> + >> +#define CSIO_ASSERT(cond) >> \ >> +do { >> \ >> +

Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-05 Thread Naresh Kumar Inna
On 9/5/2012 10:01 PM, Stephen Hemminger wrote: > On Wed, 5 Sep 2012 18:03:59 +0530 > Naresh Kumar Inna wrote: > >> +#define CSIO_ROUNDUP(__v, __r) (((__v) + (__r) - 1) / (__r)) > > This is similar to existing round_up() in kernel.h could you use that? > I will replace it with roun

Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-05 Thread Stephen Hemminger
On Wed, 5 Sep 2012 18:03:59 +0530 Naresh Kumar Inna wrote: > + > +#define CSIO_ASSERT(cond) > \ > +do { \ > + if (unlikely(!((cond\

Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-05 Thread Stephen Hemminger
On Wed, 5 Sep 2012 18:03:59 +0530 Naresh Kumar Inna wrote: > +#define CSIO_ROUNDUP(__v, __r) (((__v) + (__r) - 1) / (__r)) This is similar to existing round_up() in kernel.h could you use that? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of

[V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-05 Thread Naresh Kumar Inna
This patch contains the first set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna --- V2: - Removed csio_fcoe_proto.h, using defines from include/scsi/fc instead. - Removed driver-specific return values, using errno values instead. - Retained CSIO_INC_STATS, since it is