Re: [UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

2008-01-26 Thread Thomas Bogendoerfer
On Fri, Jan 25, 2008 at 10:44:40AM -0600, James Bottomley wrote: > > + void *cpu; > > + void *dev; > > This should be struct device *dev; shouldn't it (that seems to be how > it's always used)? of course, no need for the void *. > And that should be dma_free_noncoherent(&pdev->dev, ...) shou

[UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

2008-01-26 Thread Thomas Bogendoerfer
SGI IP28 machines would need special treatment (enable adding addtional wait states) when accessing memory uncached. To avoid this pain I changed the driver to use only cached access to memory. Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- Changes to last version: - struct device *

Re: [UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

2008-01-25 Thread James Bottomley
On Fri, 2008-01-25 at 17:32 +0100, Thomas Bogendoerfer wrote: > SGI IP28 machines would need special treatment (enable adding addtional > wait states) when accessing memory uncached. To avoid this pain I > changed the driver to use only cached access to memory. > > Signed-off-by: Thomas Bogendoerf

[UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

2008-01-25 Thread Thomas Bogendoerfer
SGI IP28 machines would need special treatment (enable adding addtional wait states) when accessing memory uncached. To avoid this pain I changed the driver to use only cached access to memory. Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- Changes to last version: - added Kconfig ch

Re: [UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

2007-12-08 Thread Ralf Baechle
On Sun, Dec 02, 2007 at 11:33:09AM +0100, Thomas Bogendoerfer wrote: > SGI IP28 machines would need special treatment (enable adding addtional > wait states) when accessing memory uncached. To avoid this pain I > changed the driver to use only cached access to memory. > > Signed-off-by: Thomas Bo

[UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

2007-12-02 Thread Thomas Bogendoerfer
SGI IP28 machines would need special treatment (enable adding addtional wait states) when accessing memory uncached. To avoid this pain I changed the driver to use only cached access to memory. Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> --- Changes to last version: - added Kconfig ch

[UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

2007-11-28 Thread Thomas Bogendoerfer
Changes to last version: - no additional padding of hpc descriptor - one dma_cache_sync after hpc descriptors are setup is enough Thomas. SGI IP28 machines would need special treatment (enable adding addtional wait states) when accessing memory uncached. To avoid this pain I changed the driver to