Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-10-01 Thread Ric Wheeler
On 09/25/2012 04:08 PM, James Bottomley wrote: On Tue, 2012-09-25 at 01:21 -0400, Jeff Garzik wrote: On 09/25/2012 12:06 AM, James Bottomley wrote: On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: drivers/scsi/sd.c |4 drivers/scsi/sd.h |2 +- 2 files changed, 5 insert

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-28 Thread Dan Williams
On Wed, Sep 26, 2012 at 7:20 PM, Martin K. Petersen wrote: >> "James" == James Bottomley >> writes: > > James> On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: >>> >>> drivers/scsi/sd.c | 4 drivers/scsi/sd.h | 2 +- 2 files changed, >>> 5 insertions(+), 1 deletion(-) > > James>

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-26 Thread Jeff Garzik
On 09/25/2012 06:38 AM, James Bottomley wrote: On Tue, 2012-09-25 at 01:21 -0400, Jeff Garzik wrote: Can you be more specific about sysfs location? A runtime-writable (via sysfs!) module parameter for a module-wide default seemed appropriate. Well, if it's really important, the same thing sho

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-26 Thread James Bottomley
On Wed, 2012-09-26 at 22:20 -0400, Martin K. Petersen wrote: > > "James" == James Bottomley > > writes: > > James> On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: > >> > >> drivers/scsi/sd.c | 4 drivers/scsi/sd.h | 2 +- 2 files changed, > >> 5 insertions(+), 1 deletion(-) >

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-26 Thread Martin K. Petersen
> "James" == James Bottomley writes: James> On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: >> >> drivers/scsi/sd.c | 4 drivers/scsi/sd.h | 2 +- 2 files changed, >> 5 insertions(+), 1 deletion(-) James> I'm not opposed in principle to doing this (except that it should James> be a

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-25 Thread James Bottomley
On Tue, 2012-09-25 at 01:21 -0400, Jeff Garzik wrote: > On 09/25/2012 12:06 AM, James Bottomley wrote: > > On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: > >> > >> drivers/scsi/sd.c |4 > >> drivers/scsi/sd.h |2 +- > >> 2 files changed, 5 insertions(+), 1 deletion(-) > > >

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-24 Thread Jeff Garzik
On 09/25/2012 12:06 AM, James Bottomley wrote: On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: drivers/scsi/sd.c |4 drivers/scsi/sd.h |2 +- 2 files changed, 5 insertions(+), 1 deletion(-) I'm not opposed in principle to doing this (except that it should be a sysfs par

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-24 Thread James Bottomley
On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: > > drivers/scsi/sd.c |4 > drivers/scsi/sd.h |2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) I'm not opposed in principle to doing this (except that it should be a sysfs parameter like all our other controls), but what'

[SCSI PATCH] sd: max-retries becomes configurable

2012-09-24 Thread Jeff Garzik
drivers/scsi/sd.c |4 drivers/scsi/sd.h |2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 4df73e5..d15074b 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -92,6 +92,10 @@ MODULE_ALIAS_SCSI_DEVICE(TYPE_DISK); M