Re: [RFC PATCH v2] scsi: scan: map PQ=1, PDT=other values to SCSI_SCAN_TARGET_PRESENT

2019-04-15 Thread Martin K. Petersen
Li, > commit 84961f28e9d1 ("[SCSI] Don't add scsi_device for devices that > return PQ=1, PDT=0x1f") returns SCSI_SCAN_TARGET_PRESENT if inquiry > returns PQ=1, and PDT = 0x1f. However, from the scsi spec, it seemed > setting PQ=1, and PDT to the type it is capable to support, can also > mean the

Re: [RFC PATCH v2] scsi: scan: map PQ=1, PDT=other values to SCSI_SCAN_TARGET_PRESENT

2019-04-15 Thread Bart Van Assche
On Mon, 2019-04-15 at 13:20 +0800, Li Zhong wrote: > diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c > index 53380e07b40e..058079f915f1 100644 > --- a/drivers/scsi/scsi_scan.c > +++ b/drivers/scsi/scsi_scan.c > @@ -1129,7 +1129,8 @@ static int scsi_probe_and_add_lun(struct scsi_tar

[RFC PATCH v2] scsi: scan: map PQ=1, PDT=other values to SCSI_SCAN_TARGET_PRESENT

2019-04-14 Thread Li Zhong
commit 84961f28e9d1 ("[SCSI] Don't add scsi_device for devices that return PQ=1, PDT=0x1f") returns SCSI_SCAN_TARGET_PRESENT if inquiry returns PQ=1, and PDT = 0x1f. However, from the scsi spec, it seemed setting PQ=1, and PDT to the type it is capable to support, can also mean the device is not co