Re: [RFC PATCH 3/3] blk_end_request: caller change

2007-01-11 Thread Kiyoshi Ueda
Hi Jens, On Thu, 11 Jan 2007 09:34:31 +0100, Jens Axboe <[EMAIL PROTECTED]> wrote: > > +static int cdrom_newpc_intr_dma_callback(void *arg) > > +{ > > + void **argv = (void **)arg; > > + struct request *rq = (struct request *)*argv++; > > + ide_drive_t *drive = (ide_drive_t *)argv++; > > +

Re: [RFC PATCH 3/3] blk_end_request: caller change

2007-01-11 Thread Jens Axboe
On Wed, Jan 10 2007, Kiyoshi Ueda wrote: > +static int end_request_callback(void *arg) > +{ > + struct request *req = (struct request *)arg; > + > + add_disk_randomness(req->rq_disk); > + blkdev_dequeue_request(req); > + > + return 0; > +} This is bad, don't pass void * around. >

[RFC PATCH 3/3] blk_end_request: caller change

2007-01-10 Thread Kiyoshi Ueda
This patch replaces caller's end_that_request_* to blk_end_request. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- block/elevator.c|3 - block/ll_rw_blk.c | 26 +++- drivers/block/DAC960.c