Re: future FCoE ideas (Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces)

2012-09-14 Thread Love, Robert W
On Thu 13 Sep 2012 03:45:33 PM PDT, Love, Robert W wrote: > On Thu 13 Sep 2012 03:32:50 PM PDT, Chris Leech wrote: >> > anymore> >> That being said, I'm glad this is being reworked. Do you have any other functionality in mind that this is laying the groundwork for? >>> >>> I have on

Re: future FCoE ideas (Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces)

2012-09-13 Thread Love, Robert W
On Thu 13 Sep 2012 03:32:50 PM PDT, Chris Leech wrote: > anymore> > >>> That being said, I'm glad this is being reworked. Do you have any >>> other functionality in mind that this is laying the groundwork for? >>> >> >> I have one feature and a few ideas. I currently have a patch that adds >> a f

future FCoE ideas (Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces)

2012-09-13 Thread Chris Leech
>> That being said, I'm glad this is being reworked. Do you have any >> other functionality in mind that this is laying the groundwork for? >> > > I have one feature and a few ideas. I currently have a patch that adds > a fabric selection feature. I add another RW attribute to the ctlr_X > devic

Re: [Open-FCoE] [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-12 Thread Love, Robert W
On 12-09-11 10:36 AM, Love, Robert W wrote: > On Tue 11 Sep 2012 10:06:29 AM PDT, Chris Leech wrote: >> On Mon, Sep 10, 2012 at 3:59 PM, Robert Love wrote: > This feels a little awkward with all the special control files. Have > you thought about something designed for creating kernel objects,

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Love, Robert W
On Tue 11 Sep 2012 11:31:08 AM PDT, Bhanu Prakash Gollapudi wrote: > On 9/11/2012 10:36 AM, Love, Robert W wrote: >> On Tue 11 Sep 2012 10:06:29 AM PDT, Chris Leech wrote: >>> On Mon, Sep 10, 2012 at 3:59 PM, Robert Love >>> wrote: >> >> >> 1) Create/alloc the port - Allocate kerne

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Bhanu Prakash Gollapudi
On 9/11/2012 10:36 AM, Love, Robert W wrote: On Tue 11 Sep 2012 10:06:29 AM PDT, Chris Leech wrote: On Mon, Sep 10, 2012 at 3:59 PM, Robert Love wrote: 1) Create/alloc the port - Allocate kernel memory and create per-instance sysfs devices - No discovery or login # echo eth3.1

Re: [Open-FCoE] [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Love, Robert W
On Tue 11 Sep 2012 10:36:35 AM PDT, Love, Robert W wrote: > On Tue 11 Sep 2012 10:06:29 AM PDT, Chris Leech wrote: >> On Mon, Sep 10, 2012 at 3:59 PM, Robert Love wrote: >> That being said, I'm glad this is being reworked. Do you have any >> other functionality in mind that this is laying the

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Love, Robert W
On Tue 11 Sep 2012 10:12:09 AM PDT, Chris Leech wrote: > On Mon, Sep 10, 2012 at 5:05 PM, Bhanu Prakash Gollapudi > wrote: >> >> I'm concerned that we will be breaking user space compatibility with this >> change, as there should be a corresponding fcoemon/fipvlan change along with >> this, and ex

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Love, Robert W
On Tue 11 Sep 2012 10:06:29 AM PDT, Chris Leech wrote: > On Mon, Sep 10, 2012 at 3:59 PM, Robert Love wrote: >> 1) Create/alloc the port >> - Allocate kernel memory and create per-instance sysfs devices >> - No discovery or login >> # echo eth3.172-fcoe > /sys/bus/fcoe/ctlr_create res

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Chris Leech
On Mon, Sep 10, 2012 at 5:05 PM, Bhanu Prakash Gollapudi wrote: > > I'm concerned that we will be breaking user space compatibility with this > change, as there should be a corresponding fcoemon/fipvlan change along with > this, and existing utilities will not work. Also the way we start fcoe wil

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-11 Thread Chris Leech
On Mon, Sep 10, 2012 at 3:59 PM, Robert Love wrote: > The following series implements a move from using module parameters > as control interfaces to /sys/bus/fcoe based interfaces. A sysfs > infrastructure > was added to the kernel a few cycles ago, this series builds on that work. > > It moves t

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-10 Thread Bhanu Prakash Gollapudi
On 9/10/2012 6:41 PM, Love, Robert W wrote: On Mon 10 Sep 2012 05:05:20 PM PDT, Bhanu Prakash Gollapudi wrote: On 9/10/2012 3:59 PM, Robert Love wrote: The following series implements a move from using module parameters as control interfaces to /sys/bus/fcoe based interfaces. A sysfs infrastruc

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-10 Thread Love, Robert W
On Mon 10 Sep 2012 05:05:20 PM PDT, Bhanu Prakash Gollapudi wrote: > On 9/10/2012 3:59 PM, Robert Love wrote: >> The following series implements a move from using module parameters >> as control interfaces to /sys/bus/fcoe based interfaces. A sysfs >> infrastructure >> was added to the kernel a few

Re: [RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-10 Thread Bhanu Prakash Gollapudi
On 9/10/2012 3:59 PM, Robert Love wrote: The following series implements a move from using module parameters as control interfaces to /sys/bus/fcoe based interfaces. A sysfs infrastructure was added to the kernel a few cycles ago, this series builds on that work. It moves the create, vn2vn_creat

[RFC PATCH 0/5] Reorganize libfcoe control interfaces

2012-09-10 Thread Robert Love
The following series implements a move from using module parameters as control interfaces to /sys/bus/fcoe based interfaces. A sysfs infrastructure was added to the kernel a few cycles ago, this series builds on that work. It moves the create, vn2vn_create, destroy, enable and disable interfaces f