Re: [RFC PATCH] scsi: sd: add wce_rcd sysfs interface

2018-01-17 Thread weiping zhang
2018-01-18 10:51 GMT+08:00 Martin K. Petersen : > > Hi Weiping, > >> add user friendly interface wce_rcd to enable/disable >> write&read cache. The code base on cache_type, but need short input. > > While I agree that the cache_type interface is somewhat arcane, I don't > think that adding a duplic

Re: [RFC PATCH] scsi: sd: add wce_rcd sysfs interface

2018-01-17 Thread Martin K. Petersen
Hi Weiping, > add user friendly interface wce_rcd to enable/disable > write&read cache. The code base on cache_type, but need short input. While I agree that the cache_type interface is somewhat arcane, I don't think that adding a duplicate interface with slightly different semantics is a good i

[RFC PATCH] scsi: sd: add wce_rcd sysfs interface

2018-01-17 Thread weiping zhang
add user friendly interface wce_rcd to enable/disable write&read cache. The code base on cache_type, but need short input. enable both write and read cache: echo "10" > wce_rcd wce rcd write_cache read_cache 0 0 off on 0 1 off off 1 0 on on 1 1 on