RE: [RFC 4/8] p2pmem: Add debugfs "stats" file

2017-04-05 Thread Steve Wise
> > > + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); > > + if (!p2pmem_debugfs_root) > > + pr_info("could not create debugfs entry, continuing\n"); > > + > > Why continue? I think it'd be better to just fail it. > Because not having debugfs support isn't fatal to usin

Re: [RFC 4/8] p2pmem: Add debugfs "stats" file

2017-04-04 Thread Logan Gunthorpe
On 04/04/17 04:46 AM, Sagi Grimberg wrote: > >> +p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); >> +if (!p2pmem_debugfs_root) >> +pr_info("could not create debugfs entry, continuing\n"); >> + > > Why continue? I think it'd be better to just fail it. Yup, agreed. This

Re: [RFC 4/8] p2pmem: Add debugfs "stats" file

2017-04-04 Thread Sagi Grimberg
+ p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); + if (!p2pmem_debugfs_root) + pr_info("could not create debugfs entry, continuing\n"); + Why continue? I think it'd be better to just fail it. Besides, this can be safely squashed into patch 1.

[RFC 4/8] p2pmem: Add debugfs "stats" file

2017-03-30 Thread Logan Gunthorpe
From: Steve Wise For each p2pmem instance, add a "stats" file to show the gen_pool statistics. Signed-off-by: Steve Wise Signed-off-by: Logan Gunthorpe Signed-off-by: Stephen Bates --- drivers/memory/p2pmem.c | 49 + include/linux/p2pmem.h |