Re: [RFC 14/34] iscsi-target: export symbols

2016-04-10 Thread Sagi Grimberg
Great. Just curious how -v2 is coming along..? I've got a few cycles over the weekend, and plan to start reviewing as the series hits the list. Btw, I asked Sagi to help out with review as well. If you did, it's lost in my old email address :) I'll have a look this week. Cheers, Sagi. --

Re: [RFC 14/34] iscsi-target: export symbols

2016-04-09 Thread Varun Prakash
On Fri, Apr 08, 2016 at 12:16:43AM -0700, Nicholas A. Bellinger wrote: > On Sun, 2016-03-13 at 17:43 +0530, Varun Prakash wrote: > > On Fri, Mar 11, 2016 at 10:28:33PM -0800, Nicholas A. Bellinger wrote: > > > Hi Varun & Co, > > > > > > On Mon, 2016-03-07 at 15:22 -0800, Nicholas A. Bellinger wrot

Re: [RFC 14/34] iscsi-target: export symbols

2016-04-08 Thread Nicholas A. Bellinger
On Sun, 2016-03-13 at 17:43 +0530, Varun Prakash wrote: > On Fri, Mar 11, 2016 at 10:28:33PM -0800, Nicholas A. Bellinger wrote: > > Hi Varun & Co, > > > > On Mon, 2016-03-07 at 15:22 -0800, Nicholas A. Bellinger wrote: > > > > > > > > > So obviously this is going to take longer to sort out, an

Re: [RFC 14/34] iscsi-target: export symbols

2016-03-13 Thread Varun Prakash
On Fri, Mar 11, 2016 at 10:28:33PM -0800, Nicholas A. Bellinger wrote: > Hi Varun & Co, > > On Mon, 2016-03-07 at 15:22 -0800, Nicholas A. Bellinger wrote: > > > > > So obviously this is going to take longer to sort out, and likely not > > end up being v4.6-rc1 material. That is OK, as the end

Re: [RFC 14/34] iscsi-target: export symbols

2016-03-11 Thread Nicholas A. Bellinger
Hi Varun & Co, On Mon, 2016-03-07 at 15:22 -0800, Nicholas A. Bellinger wrote: > So obviously this is going to take longer to sort out, and likely not > end up being v4.6-rc1 material. That is OK, as the end result will be > better code. :) > > That said, it would make sense do the initial m

Re: [RFC 14/34] iscsi-target: export symbols

2016-03-07 Thread Nicholas A. Bellinger
On Sat, 2016-03-05 at 13:54 -0800, Nicholas A. Bellinger wrote: > Hi Varun & Co, > > On Wed, 2016-03-02 at 17:30 +0530, Varun Prakash wrote: > > On Tue, Mar 01, 2016 at 08:19:21PM +0530, Christoph Hellwig wrote: > > > This looks like pretty random exports and not something like a well > > > define

Re: [RFC 14/34] iscsi-target: export symbols

2016-03-05 Thread Nicholas A. Bellinger
Hi Varun & Co, On Wed, 2016-03-02 at 17:30 +0530, Varun Prakash wrote: > On Tue, Mar 01, 2016 at 08:19:21PM +0530, Christoph Hellwig wrote: > > This looks like pretty random exports and not something like a well > > defined interface to me :( > > I have exported functions which works on iscsi-tar

Re: [RFC 14/34] iscsi-target: export symbols

2016-03-02 Thread Varun Prakash
On Tue, Mar 01, 2016 at 08:19:21PM +0530, Christoph Hellwig wrote: > This looks like pretty random exports and not something like a well > defined interface to me :( I have exported functions which works on iscsi-target data structures and can be reused by offload drivers. -- To unsubscribe from t

Re: [RFC 14/34] iscsi-target: export symbols

2016-03-01 Thread Christoph Hellwig
This looks like pretty random exports and not something like a well defined interface to me :( -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[RFC 14/34] iscsi-target: export symbols

2016-02-14 Thread Varun Prakash
export multiple symbols for ISCSI_TCP_CXGB4 transport driver. Signed-off-by: Varun Prakash --- drivers/target/iscsi/iscsi_target_datain_values.c | 3 ++ drivers/target/iscsi/iscsi_target_erl0.c | 1 + drivers/target/iscsi/iscsi_target_erl1.c | 1 + drivers/target/iscsi/iscsi