Re: [RFC 01/11] iscsi-target: Add iscsit_transport API template

2013-03-22 Thread Nicholas A. Bellinger
On Fri, 2013-03-22 at 10:23 -0700, Andy Grover wrote: > On 03/07/2013 05:45 PM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Add basic struct iscsit_transport API template to allow iscsi-target for > > running with external transport modules using existing iscsi_target_core.h

Re: [RFC 01/11] iscsi-target: Add iscsit_transport API template

2013-03-22 Thread Andy Grover
On 03/07/2013 05:45 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger Add basic struct iscsit_transport API template to allow iscsi-target for running with external transport modules using existing iscsi_target_core.h code. For all external modules, this calls try_module_get() and modu

Re: [RFC 01/11] iscsi-target: Add iscsit_transport API template

2013-03-08 Thread Nicholas A. Bellinger
On Fri, 2013-03-08 at 14:36 +0200, Or Gerlitz wrote: > On Fri, Mar 8, 2013 at 6:14 AM, Roland Dreier wrote: > > Nicholas A. Bellinger wrote: > > > +EXPORT_SYMBOL(iscsit_get_transport); > > > It's not clear to me why this needs to be exported. Who would use it > > outside the core iscsi target m

Re: [RFC 01/11] iscsi-target: Add iscsit_transport API template

2013-03-08 Thread Roland Dreier
On Thu, Mar 7, 2013 at 10:02 PM, Nicholas A. Bellinger wrote: > Or and I discussed this point in the last status call, and given what > the initiator did originally (eg: export iscsi_transport) he asked to > keep it under drivers/infiniband/ulp/isert/ with the extra include bits. > > I'd have a sl

Re: [RFC 01/11] iscsi-target: Add iscsit_transport API template

2013-03-08 Thread Or Gerlitz
On Fri, Mar 8, 2013 at 6:14 AM, Roland Dreier wrote: > Nicholas A. Bellinger wrote: > > +EXPORT_SYMBOL(iscsit_get_transport); > It's not clear to me why this needs to be exported. Who would use it > outside the core iscsi target module? Yep, as Nic noted, we're adding here an iscsi transport c

Re: [RFC 01/11] iscsi-target: Add iscsit_transport API template

2013-03-07 Thread Nicholas A. Bellinger
On Thu, 2013-03-07 at 20:14 -0800, Roland Dreier wrote: > On Thu, Mar 7, 2013 at 5:45 PM, Nicholas A. Bellinger > wrote: > > +EXPORT_SYMBOL(iscsit_get_transport); > > It's not clear to me why this needs to be exported. Who would use it > outside the core iscsi target module? Oversight on my par

Re: [RFC 01/11] iscsi-target: Add iscsit_transport API template

2013-03-07 Thread Roland Dreier
On Thu, Mar 7, 2013 at 5:45 PM, Nicholas A. Bellinger wrote: > +EXPORT_SYMBOL(iscsit_get_transport); It's not clear to me why this needs to be exported. Who would use it outside the core iscsi target module? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of

[RFC 01/11] iscsi-target: Add iscsit_transport API template

2013-03-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Add basic struct iscsit_transport API template to allow iscsi-target for running with external transport modules using existing iscsi_target_core.h code. For all external modules, this calls try_module_get() and module_put() to obtain + release an external iscsit_transpo