Re: [RFC 0/16] gdth combined patchset & call for testers

2007-10-01 Thread Boaz Harrosh
On Sun, Sep 30 2007 at 23:27 +0200, Jeff Garzik <[EMAIL PROTECTED]> wrote: > BTW, when reposting the patches of others, its nice to add a From: > header to the very first line of the email body. Andrew does that a > lot, and the git tools are aware of this convention. > Thanks, yes I was not aw

Re: [RFC 0/16] gdth combined patchset & call for testers

2007-09-30 Thread Jeff Garzik
The patchset looks pretty good to me, overall. Thanks for pulling all this stuff together! Jeff - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC 0/16] gdth combined patchset & call for testers

2007-09-30 Thread Jeff Garzik
Christoph Hellwig wrote: The big problem with the pci_driver conversion is that lack of device ids in the driver. A few years ago I sent Achim a mail to ask if there's a definitive list of used PCI ids, but didn't get an answer - maybe the mail bounced. If we can't get this list we'd have to ad

Re: [RFC 0/16] gdth combined patchset & call for testers

2007-09-30 Thread Christoph Hellwig
On Sun, Sep 30, 2007 at 05:07:53PM -0400, Jeff Garzik wrote: > The driver needs to be converted to the "new" hotplug APIs. > > The main pre-reqs are accomplished by your patches: the driver is using > the modern scsi hotplug API, and uses pointers for the adapter struct > rather than indices. >

Re: [RFC 0/16] gdth combined patchset & call for testers

2007-09-30 Thread Christoph Hellwig
On Sun, Sep 30, 2007 at 09:44:12PM +0200, Boaz Harrosh wrote: > Some short explanations: > [1/16] gdth: split out isa probing - Christoph Hellwig > [2/16] gdth: split out eisa probing - Christoph Hellwig > [3/16] gdth: split out pci probing - Christoph Hellwig > These three are from Christoph and

Re: [RFC 0/16] gdth combined patchset & call for testers

2007-09-30 Thread Jeff Garzik
BTW, when reposting the patches of others, its nice to add a From: header to the very first line of the email body. Andrew does that a lot, and the git tools are aware of this convention. Also, hey, if you like our patches, I think you should add your own Signed-off-by line (assuming/hoping y

Re: [RFC 0/16] gdth combined patchset & call for testers

2007-09-30 Thread Jeff Garzik
Boaz Harrosh wrote: [11/16] gdth: switch to modern scsi host registration - Christoph Christoph what is missing from here is the remove of the deprecated pci_find_device() call. Can I Just use pci_get_device() of the same signature or do I need to call some other pci_ members after that?

Re: [RFC 0/16] gdth combined patchset & call for testers

2007-09-30 Thread Jeff Garzik
Boaz Harrosh wrote: [8/16] gdth: Remove virt hosts - Christoph && Boaz Here we need an executive decision! The issue is as stated by Christoph: "The virt_ctr option allows to register a new scsi_host for each bus on the raid controller. This non-default option makes no sense with

[RFC 0/16] gdth combined patchset & call for testers

2007-09-30 Thread Boaz Harrosh
Hi! following is an attempted at unified patchset for the gdth driver. They try to incorporate floating patches to gdth from: Christoph Hellwig Jeff Garzik Matthew Wilcox and Me Boaz Harrosh They are done in the mindset of "likelihood of inducing breakage", hence the need for testers. Christoph