Re: [RFC] Fix device not ready printk

2007-09-23 Thread Matthew Wilcox
On Sun, Sep 23, 2007 at 09:08:46AM -0500, James Bottomley wrote: > The main thing I don't like is that we've spent a lot of time moving > sense prints into a library so that if someone gullible^Wsensible enough > to want to do a reporting infrastructure comes along, we have all the > entry points n

Re: [RFC] Fix device not ready printk

2007-09-23 Thread James Bottomley
On Thu, 2007-07-19 at 12:51 -0600, Matthew Wilcox wrote: > On Fri, Jun 29, 2007 at 07:21:26AM -0600, Matthew Wilcox wrote: > > I'm in two minds about printing the 'Device not ready' twice. On the > > one hand, it's redundant information. On the other hand, it helps the > > harried sysadmin with m

Re: [RFC] Fix device not ready printk

2007-07-19 Thread Martin K. Petersen
> "Matthew" == Matthew Wilcox <[EMAIL PROTECTED]> writes: Matthew> After three weeks with no discussion, I guess it may as well Matthew> be applied. Matthew> scsi: Better error messages when device not ready Looks good to me. Acked-by: Martin K. Petersen <[EMAIL PROTECTED]> -- Martin K. P

Re: [RFC] Fix device not ready printk

2007-07-19 Thread Matthew Wilcox
On Fri, Jun 29, 2007 at 07:21:26AM -0600, Matthew Wilcox wrote: > I'm in two minds about printing the 'Device not ready' twice. On the > one hand, it's redundant information. On the other hand, it helps the > harried sysadmin with multiple simultaneous disc failures tie the two > messages togethe

[RFC] Fix device not ready printk

2007-06-29 Thread Matthew Wilcox
scsi_print_sense_hdr prints KERN_INFO, making the output from scsi_io_completion ugly: sd 0:0:0:0: [sdb] Device not ready: <6>: Sense Key : 0x2 [current] : ASC=0x4 ASCQ=0x3 By duplicating some of the code from it, we can get the nicer output: sd 0:0:0:0: [sdb] Device not ready: Sense Key : Not