Re: [Patch] QLogic qla2x00 driver fixes

2005-02-28 Thread Doug Ledford
On Fri, 2005-02-25 at 09:02 -0800, Patrick Mansfield wrote: > On Fri, Feb 25, 2005 at 06:57:39AM -0500, Doug Ledford wrote: > > On Fri, 2005-02-25 at 03:38 -0500, Jeff Garzik wrote: > > > Arjan van de Ven wrote: > > > > On Thu, 2005-02-24 at 23:21 -0500, Doug Ledford wrote: > > > > > > > >>Don't u

Re: [Patch] QLogic qla2x00 driver fixes

2005-02-25 Thread Luben Tuikov
On 02/25/05 06:57, Doug Ledford wrote: struct is silly. Just use what's available, reliable, always initialized, and intended for you to use (cmd->use_sg) instead of trying to use a roughly duplicate item from a different abstraction layer that isn't always involved in commands sent to a low level

Re: [Patch] QLogic qla2x00 driver fixes

2005-02-25 Thread Patrick Mansfield
On Fri, Feb 25, 2005 at 06:57:39AM -0500, Doug Ledford wrote: > On Fri, 2005-02-25 at 03:38 -0500, Jeff Garzik wrote: > > Arjan van de Ven wrote: > > > On Thu, 2005-02-24 at 23:21 -0500, Doug Ledford wrote: > > > > > >>Don't use cmd->request->nr_hw_segments as it may not be initialized > > >>(SG_I

Re: [Patch] QLogic qla2x00 driver fixes

2005-02-25 Thread Doug Ledford
On Fri, 2005-02-25 at 03:38 -0500, Jeff Garzik wrote: > Arjan van de Ven wrote: > > On Thu, 2005-02-24 at 23:21 -0500, Doug Ledford wrote: > > > >>Don't use cmd->request->nr_hw_segments as it may not be initialized > >>(SG_IO in particular bypasses anything that initializes this and just > >>uses

Re: [Patch] QLogic qla2x00 driver fixes

2005-02-25 Thread Jeff Garzik
Arjan van de Ven wrote: On Thu, 2005-02-24 at 23:21 -0500, Doug Ledford wrote: Don't use cmd->request->nr_hw_segments as it may not be initialized (SG_IO in particular bypasses anything that initializes this and just uses scsi_do_req to insert a scsi_request directly on the head of the queue) sho

Re: [Patch] QLogic qla2x00 driver fixes

2005-02-24 Thread Arjan van de Ven
On Thu, 2005-02-24 at 23:21 -0500, Doug Ledford wrote: > Don't use cmd->request->nr_hw_segments as it may not be initialized > (SG_IO in particular bypasses anything that initializes this and just > uses scsi_do_req to insert a scsi_request directly on the head of the > queue) should we fix that

Re: [Patch] QLogic qla2x00 driver fixes

2005-02-24 Thread Douglas Gilbert
Doug Ledford wrote: Don't use cmd->request->nr_hw_segments as it may not be initialized (SG_IO in particular bypasses anything that initializes this and just uses scsi_do_req to insert a scsi_request directly on the head of the queue) and a bogus value here can trip up the checks to make sure that

Re: [Patch] QLogic qla2x00 driver fixes

2005-02-24 Thread Andrew Vasquez
On Thu, 24 Feb 2005, Doug Ledford wrote: > Don't use cmd->request->nr_hw_segments as it may not be initialized > (SG_IO in particular bypasses anything that initializes this and just > uses scsi_do_req to insert a scsi_request directly on the head of the > queue) > I opted to begin to use the nr_

Re: [Patch] QLogic qla2x00 driver fixes

2005-02-24 Thread Jeff Garzik
Doug Ledford wrote: Don't use cmd->request->nr_hw_segments as it may not be initialized (SG_IO in particular bypasses anything that initializes this and just uses scsi_do_req to insert a scsi_request directly on the head of the queue) and a bogus value here can trip up the checks to make sure that

[Patch] QLogic qla2x00 driver fixes

2005-02-24 Thread Doug Ledford
Don't use cmd->request->nr_hw_segments as it may not be initialized (SG_IO in particular bypasses anything that initializes this and just uses scsi_do_req to insert a scsi_request directly on the head of the queue) and a bogus value here can trip up the checks to make sure that the number of segmen