Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-11-07 Thread Johannes Thumshirn
On Mon, Nov 07, 2016 at 08:10:25PM +0100, Christoph Hellwig wrote: > On Mon, Nov 07, 2016 at 06:04:21PM +0100, Sebastian Andrzej Siewior wrote: > > So we keep things as they are right now or are we getting also rid of > > the internal list? This was tested by Johannes and Chad (claimed to do > > te

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-11-07 Thread Christoph Hellwig
On Mon, Nov 07, 2016 at 06:04:21PM +0100, Sebastian Andrzej Siewior wrote: > So we keep things as they are right now or are we getting also rid of > the internal list? This was tested by Johannes and Chad (claimed to do > testing) IFF the patches actually are tested as-is let's get them in. I don

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-11-07 Thread Sebastian Andrzej Siewior
On 2016-11-07 17:48:46 [+0100], Christoph Hellwig wrote: > On Mon, Nov 07, 2016 at 05:46:29PM +0100, Sebastian Andrzej Siewior wrote: > > sorry for the confusion in the subject. If I remember correctly you said > > that we may not have enough room for a larger / work_struct struct and I > > should

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-11-07 Thread Christoph Hellwig
On Mon, Nov 07, 2016 at 05:46:29PM +0100, Sebastian Andrzej Siewior wrote: > sorry for the confusion in the subject. If I remember correctly you said > that we may not have enough room for a larger / work_struct struct and I > should keep the list for now. But that was for libfc where it only has

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-11-07 Thread Sebastian Andrzej Siewior
On 2016-11-07 17:38:48 [+0100], Christoph Hellwig wrote: > You're right it does - between the incorrect subject and the fact > that it still keeps the linked list of items arounds instead of fully > using the workqueue infrastructure I was a bit confused before my > first coffee this morning. Same

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-11-07 Thread Christoph Hellwig
On Mon, Nov 07, 2016 at 05:31:03PM +0100, Thomas Gleixner wrote: > On Mon, 7 Nov 2016, Christoph Hellwig wrote: > > > It seems like the whole damn driver should just use threaded interrupts. > > Of course it's a giant beast and not just the iSCSI one. But even > > if we don't go all the way I'd m

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-11-07 Thread Thomas Gleixner
On Mon, 7 Nov 2016, Christoph Hellwig wrote: > It seems like the whole damn driver should just use threaded interrupts. > Of course it's a giant beast and not just the iSCSI one. But even > if we don't go all the way I'd much prefer workqueues. kthread work > is simply the worst API ever and I'd