Re: [PATCHv7 07/23] scsi_dh_alua: Use separate alua_port_group structure

2016-02-18 Thread Hannes Reinecke
On 02/18/2016 08:41 PM, Bart Van Assche wrote: > On 02/15/2016 12:24 AM, Hannes Reinecke wrote: >> if (optimize) >> -h->flags |= ALUA_OPTIMIZE_STPG; >> +pg->flags |= ALUA_OPTIMIZE_STPG; >> else >> -h->flags &= ~ALUA_OPTIMIZE_STPG; >> +pg->flags |= ~ALUA_O

Re: [PATCHv7 07/23] scsi_dh_alua: Use separate alua_port_group structure

2016-02-18 Thread Bart Van Assche
On 02/15/2016 12:24 AM, Hannes Reinecke wrote: if (optimize) - h->flags |= ALUA_OPTIMIZE_STPG; + pg->flags |= ALUA_OPTIMIZE_STPG; else - h->flags &= ~ALUA_OPTIMIZE_STPG; + pg->flags |= ~ALUA_OPTIMIZE_STPG; The above looks w

[PATCHv7 07/23] scsi_dh_alua: Use separate alua_port_group structure

2016-02-15 Thread Hannes Reinecke
The port group needs to be a separate structure as several LUNs might belong to the same group. Reviewed-by: Christoph Hellwig Reviewed-by: Ewan Milne Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 181 - include/scsi/scsi_dh.h