Re: [PATCHv3 4/6] scsi_error: do not escalate failed EH command

2017-03-23 Thread Hannes Reinecke
On 03/21/2017 08:05 PM, Benjamin Block wrote: > On Thu, Mar 16, 2017 at 12:53:45PM +0100, Hannes Reinecke wrote: >> On 03/16/2017 12:01 PM, Benjamin Block wrote: >>> On Wed, Mar 15, 2017 at 02:54:16PM +0100, Hannes Reinecke wrote: On 03/14/2017 06:56 PM, Benjamin Block wrote: > Hello Hanne

Re: [PATCHv3 4/6] scsi_error: do not escalate failed EH command

2017-03-21 Thread Benjamin Block
On Thu, Mar 16, 2017 at 12:53:45PM +0100, Hannes Reinecke wrote: >On 03/16/2017 12:01 PM, Benjamin Block wrote: >> On Wed, Mar 15, 2017 at 02:54:16PM +0100, Hannes Reinecke wrote: >>> On 03/14/2017 06:56 PM, Benjamin Block wrote: Hello Hannes, On Wed, Mar 01, 2017 at 10:15:18AM +0100

Re: [PATCHv3 4/6] scsi_error: do not escalate failed EH command

2017-03-16 Thread Hannes Reinecke
On 03/16/2017 12:01 PM, Benjamin Block wrote: > On Wed, Mar 15, 2017 at 02:54:16PM +0100, Hannes Reinecke wrote: >> On 03/14/2017 06:56 PM, Benjamin Block wrote: >>> Hello Hannes, >>> >>> On Wed, Mar 01, 2017 at 10:15:18AM +0100, Hannes Reinecke wrote: When a command is sent as part of the err

Re: [PATCHv3 4/6] scsi_error: do not escalate failed EH command

2017-03-16 Thread Benjamin Block
On Wed, Mar 15, 2017 at 02:54:16PM +0100, Hannes Reinecke wrote: > On 03/14/2017 06:56 PM, Benjamin Block wrote: > > Hello Hannes, > > > > On Wed, Mar 01, 2017 at 10:15:18AM +0100, Hannes Reinecke wrote: > >> When a command is sent as part of the error handling there > >> is not point whatsoever to

Re: [PATCHv3 4/6] scsi_error: do not escalate failed EH command

2017-03-15 Thread Hannes Reinecke
On 03/14/2017 06:56 PM, Benjamin Block wrote: > Hello Hannes, > > On Wed, Mar 01, 2017 at 10:15:18AM +0100, Hannes Reinecke wrote: >> When a command is sent as part of the error handling there >> is not point whatsoever to start EH escalation when that >> command fails; we are _already_ in the err

Re: [PATCHv3 4/6] scsi_error: do not escalate failed EH command

2017-03-14 Thread Benjamin Block
Hello Hannes, On Wed, Mar 01, 2017 at 10:15:18AM +0100, Hannes Reinecke wrote: > When a command is sent as part of the error handling there > is not point whatsoever to start EH escalation when that > command fails; we are _already_ in the error handler, > and the escalation is about to commence a

[PATCHv3 4/6] scsi_error: do not escalate failed EH command

2017-03-01 Thread Hannes Reinecke
When a command is sent as part of the error handling there is not point whatsoever to start EH escalation when that command fails; we are _already_ in the error handler, and the escalation is about to commence anyway. So just call 'scsi_try_to_abort_cmd()' to abort outstanding commands and let the