Re: [PATCHv2 05/14] libata: NCQ Encapsulation for READ LOG DMA EXT

2016-04-15 Thread Hannes Reinecke
On 04/14/2016 06:07 PM, Tejun Heo wrote: > On Thu, Apr 14, 2016 at 05:59:48PM +0200, Hannes Reinecke wrote: >> For this patch, yes, you are right. >> However, the ZAC enablement patches later on submit READ LOG EXT commands >> (for REPORT ZONES), and _they_ benefit from NCQ encapsulation. > > Umm.

Re: [PATCHv2 05/14] libata: NCQ Encapsulation for READ LOG DMA EXT

2016-04-14 Thread Tejun Heo
On Thu, Apr 14, 2016 at 05:59:48PM +0200, Hannes Reinecke wrote: > For this patch, yes, you are right. > However, the ZAC enablement patches later on submit READ LOG EXT commands > (for REPORT ZONES), and _they_ benefit from NCQ encapsulation. Umm... so, you can't use ata_exec_internal() outside o

Re: [PATCHv2 05/14] libata: NCQ Encapsulation for READ LOG DMA EXT

2016-04-14 Thread Hannes Reinecke
On 04/14/2016 05:43 PM, Tejun Heo wrote: Hello, Hannes. On Thu, Apr 14, 2016 at 07:44:19AM +0200, Hannes Reinecke wrote: Hehe. No, it isn't, if you look closely. (Or make that: it _shouldn't_, and I've messed it up) (That's what the 'fpdma' parameter is for) The benefit is not so much for norm

Re: [PATCHv2 05/14] libata: NCQ Encapsulation for READ LOG DMA EXT

2016-04-14 Thread Tejun Heo
Hello, Hannes. On Thu, Apr 14, 2016 at 07:44:19AM +0200, Hannes Reinecke wrote: > Hehe. No, it isn't, if you look closely. > (Or make that: it _shouldn't_, and I've messed it up) > (That's what the 'fpdma' parameter is for) > > The benefit is not so much for normal operations, but it'll give us >

Re: [PATCHv2 05/14] libata: NCQ Encapsulation for READ LOG DMA EXT

2016-04-13 Thread Hannes Reinecke
On 04/13/2016 08:07 PM, Tejun Heo wrote: > On Tue, Apr 12, 2016 at 08:47:49AM +0200, Hannes Reinecke wrote: >> Recent devices can use NCQ encapsulation for READ LOG DMA EXT, >> so we should be using it if available. > > Does this have any actual benefits than being new and shiny? It's > being cal

Re: [PATCHv2 05/14] libata: NCQ Encapsulation for READ LOG DMA EXT

2016-04-13 Thread Tejun Heo
On Tue, Apr 12, 2016 at 08:47:49AM +0200, Hannes Reinecke wrote: > Recent devices can use NCQ encapsulation for READ LOG DMA EXT, > so we should be using it if available. Does this have any actual benefits than being new and shiny? It's being called from EH path where we know that no other comman

[PATCHv2 05/14] libata: NCQ Encapsulation for READ LOG DMA EXT

2016-04-11 Thread Hannes Reinecke
Recent devices can use NCQ encapsulation for READ LOG DMA EXT, so we should be using it if available. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-core.c | 5 ++--- drivers/ata/libata-eh.c | 30 +- drivers/ata/libata.h | 5 +++-- include/linux/ata.h