Re: [PATCHv2] scsi: ibmvscsis: Fix a stringop-overflow warning

2018-09-11 Thread Kees Cook
On Tue, Sep 11, 2018 at 11:24 AM, Kees Cook wrote: > On Tue, Sep 11, 2018 at 11:05 AM, Laura Abbott wrote: >> >> There's currently a warning about string overflow with strncat: >> >> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_probe': >> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt

Re: [PATCHv2] scsi: ibmvscsis: Fix a stringop-overflow warning

2018-09-11 Thread Kees Cook
On Tue, Sep 11, 2018 at 11:05 AM, Laura Abbott wrote: > > There's currently a warning about string overflow with strncat: > > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_probe': > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3479:2: error: 'strncat' specified > bound 64 equals des

[PATCHv2] scsi: ibmvscsis: Fix a stringop-overflow warning

2018-09-11 Thread Laura Abbott
There's currently a warning about string overflow with strncat: drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_probe': drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3479:2: error: 'strncat' specified bound 64 equals destination size [-Werror=stringop-overflow=] strncat(vscsi->eye,