Re: [PATCHv2] libsas: Check for completed commands before calling lldd_abort_task()

2018-01-09 Thread Yves-Alexis Perez
On Tue, 2018-01-09 at 10:30 +0100, Hannes Reinecke wrote: > Can you try to boot the stock 4.15 kernel (without any patches) with > scsi_mod.scsi_logging_level=9411 > on the kernel commandline and send me tha output? > I really would like to see which command fails. > THX. Here it is: [ 204.96050

Re: [PATCHv2] libsas: Check for completed commands before calling lldd_abort_task()

2018-01-09 Thread Hannes Reinecke
On 01/08/2018 06:11 PM, Yves-Alexis Perez wrote: > On Mon, 2018-01-08 at 13:04 +0100, Hannes Reinecke wrote: >> The abort handler might be racing with command completion, so the >> task might already be NULL by the time the abort handler is called. > > Hi, > > I tried the patch on top of 4.15-rc7

Re: [PATCHv2] libsas: Check for completed commands before calling lldd_abort_task()

2018-01-09 Thread Hannes Reinecke
On 01/09/2018 10:04 AM, Jason Yan wrote: > > On 2018/1/9 15:34, Hannes Reinecke wrote: >> On 01/09/2018 05:09 AM, Jason Yan wrote: >>> Hannes, >>> >>> On 2018/1/8 20:04, Hannes Reinecke wrote: The abort handler might be racing with command completion, so the task might already be NULL by

Re: [PATCHv2] libsas: Check for completed commands before calling lldd_abort_task()

2018-01-09 Thread Jason Yan
On 2018/1/9 15:34, Hannes Reinecke wrote: On 01/09/2018 05:09 AM, Jason Yan wrote: Hannes, On 2018/1/8 20:04, Hannes Reinecke wrote: The abort handler might be racing with command completion, so the task might already be NULL by the time the abort handler is called. Signed-off-by: Hannes Rei

Re: [PATCHv2] libsas: Check for completed commands before calling lldd_abort_task()

2018-01-08 Thread Hannes Reinecke
On 01/09/2018 05:09 AM, Jason Yan wrote: > Hannes, > > On 2018/1/8 20:04, Hannes Reinecke wrote: >> The abort handler might be racing with command completion, so the >> task might already be NULL by the time the abort handler is called. >> >> Signed-off-by: Hannes Reinecke >> --- >>   drivers/scs

Re: [PATCHv2] libsas: Check for completed commands before calling lldd_abort_task()

2018-01-08 Thread Jason Yan
Hannes, On 2018/1/8 20:04, Hannes Reinecke wrote: The abort handler might be racing with command completion, so the task might already be NULL by the time the abort handler is called. Signed-off-by: Hannes Reinecke --- drivers/scsi/libsas/sas_scsi_host.c | 22 +++--- 1 file

Re: [PATCHv2] libsas: Check for completed commands before calling lldd_abort_task()

2018-01-08 Thread Yves-Alexis Perez
On Mon, 2018-01-08 at 13:04 +0100, Hannes Reinecke wrote: > The abort handler might be racing with command completion, so the > task might already be NULL by the time the abort handler is called. Hi, I tried the patch on top of 4.15-rc7 (and without the revert of 90965761). I don't have the NULL

[PATCHv2] libsas: Check for completed commands before calling lldd_abort_task()

2018-01-08 Thread Hannes Reinecke
The abort handler might be racing with command completion, so the task might already be NULL by the time the abort handler is called. Signed-off-by: Hannes Reinecke --- drivers/scsi/libsas/sas_scsi_host.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a