Re: [PATCH ver3 1/5] scsi_error: code cleanup before refactoring of scsi_send_eh_cmnd()

2007-09-11 Thread Boaz Harrosh
On Tue, Sep 11 2007 at 18:41 +0300, Alan Stern <[EMAIL PROTECTED]> wrote: > On Tue, 11 Sep 2007, Boaz Harrosh wrote: > >> - regrouped variables for easier reviewing of next patch >> - Support of cmnd==NULL in call to scsi_send_eh_cmnd() >> - In the copy_sense case set transfer size to the mi

Re: [PATCH ver3 1/5] scsi_error: code cleanup before refactoring of scsi_send_eh_cmnd()

2007-09-11 Thread Alan Stern
On Tue, 11 Sep 2007, Boaz Harrosh wrote: > - regrouped variables for easier reviewing of next patch > - Support of cmnd==NULL in call to scsi_send_eh_cmnd() > - In the copy_sense case set transfer size to the minimum > size of sense_buffer and passed @sense_bytes. cmnd[4] is > set ac

Re: [PATCH ver3 1/5] scsi_error: code cleanup before refactoring of scsi_send_eh_cmnd()

2007-09-11 Thread Benny Halevy
On Sep 11, 2007, 11:11 +0300, "Julian Calaby" <[EMAIL PROTECTED]> wrote: > (added CCs - that's what you get for sending emails after 5.) > > On 9/11/07, Boaz Harrosh <[EMAIL PROTECTED]> wrote: >> static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, unsigned char *cmnd, >> -

Re: [PATCH ver3 1/5] scsi_error: code cleanup before refactoring of scsi_send_eh_cmnd()

2007-09-11 Thread Julian Calaby
(added CCs - that's what you get for sending emails after 5.) On 9/11/07, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, unsigned char *cmnd, > -int cmnd_size, int timeout, int copy_sense) > +

[PATCH ver3 1/5] scsi_error: code cleanup before refactoring of scsi_send_eh_cmnd()

2007-09-11 Thread Boaz Harrosh
- regrouped variables for easier reviewing of next patch - Support of cmnd==NULL in call to scsi_send_eh_cmnd() - In the copy_sense case set transfer size to the minimum size of sense_buffer and passed @sense_bytes. cmnd[4] is set accordingly. - REQUEST_SENSE is set into cmnd[0] so