Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-11 Thread John Paul Adrian Glaubitz
On 04/11/2018 10:55 AM, Michael Schmitz wrote: Would be nice but this has been chugging along for over four years in my queue so I'm sure it can wait a few more weeks :-) But the driver works very well now, so it was worth the wait ;-). -- .''`. John Paul Adrian Glaubitz : :' : Debian Devel

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-11 Thread Michael Schmitz
Hi Geert, Christoph, Am 11.04.2018 um 20:30 schrieb Geert Uytterhoeven: > Hi Christoph, > > On Wed, Apr 11, 2018 at 10:11 AM, Christoph Hellwig > wrote: >> On Wed, Apr 11, 2018 at 10:03:12AM +0200, Geert Uytterhoeven wrote: That would be cool. Would that still be in time for the 4.17 merge

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-11 Thread Michael Schmitz
Hi Geert, Am 11.04.2018 um 18:51 schrieb Geert Uytterhoeven: > Hi Michael, > > On Tue, Apr 10, 2018 at 11:50 PM, Michael Schmitz > wrote: Short of a complete rewrite of the Zorro driver support code to be closer to what PCI does, I don' see what can be done about the use of Zorro

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-11 Thread Geert Uytterhoeven
Hi Christoph, On Wed, Apr 11, 2018 at 10:11 AM, Christoph Hellwig wrote: > On Wed, Apr 11, 2018 at 10:03:12AM +0200, Geert Uytterhoeven wrote: >> > That would be cool. Would that still be in time for the 4.17 merge? >> >> Nope, as new drivers need to be in linux-next before the merge window opens

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-11 Thread Christoph Hellwig
On Wed, Apr 11, 2018 at 10:03:12AM +0200, Geert Uytterhoeven wrote: > > That would be cool. Would that still be in time for the 4.17 merge? > > Nope, as new drivers need to be in linux-next before the merge window opens. I always throught that entirely new drivers were an exception to that.

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-11 Thread Geert Uytterhoeven
Hi Adrian, On Wed, Apr 11, 2018 at 9:59 AM, John Paul Adrian Glaubitz wrote: > On 04/11/2018 08:51 AM, Geert Uytterhoeven wrote: >> I don't have a preference. If you think it makes the driver easier to >> read, >> go for it. > > That would be cool. Would that still be in time for the 4.17 merge?

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-11 Thread John Paul Adrian Glaubitz
On 04/11/2018 08:51 AM, Geert Uytterhoeven wrote: I don't have a preference. If you think it makes the driver easier to read, go for it. That would be cool. Would that still be in time for the 4.17 merge? Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.o

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-10 Thread Geert Uytterhoeven
Hi Michael, On Tue, Apr 10, 2018 at 11:50 PM, Michael Schmitz wrote: > On Tue, Apr 10, 2018 at 8:18 PM, Geert Uytterhoeven > wrote: >> On Tue, Apr 10, 2018 at 4:16 AM, Michael Schmitz >> wrote: >>> On Mon, Apr 9, 2018 at 7:50 PM, Christoph Hellwig >>> wrote: On Sun, Apr 08, 2018 at 02:4

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-10 Thread Michael Schmitz
Hi Geert, now I see, thanks. I could change the device table to use ZORRO_ID(PHASE5, ...) style IDs instead of the longish defines if you're OK with that. The other changes have passed tests and I'd otherwise just send what I have now, adding Christoph's Reviewed-by. Cheers, Michael On Tue

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-10 Thread Geert Uytterhoeven
Hi Michael, On Tue, Apr 10, 2018 at 4:16 AM, Michael Schmitz wrote: > On Mon, Apr 9, 2018 at 7:50 PM, Christoph Hellwig wrote: >> On Sun, Apr 08, 2018 at 02:45:32PM +1200, Michael Schmitz wrote: >>> New combined SCSI driver for all ESP based Zorro SCSI boards for >>> m68k Amiga. >>> + { >>>

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-09 Thread Michael Schmitz
Hi Christoph, thanks for your review. Short of a complete rewrite of the Zorro driver support code to be closer to what PCI does, I don' see what can be done about the use of Zorro IDs. I don't think such a rewrite is planned in the near future, Geert? I can certainly use board type enums as ind

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-09 Thread Geert Uytterhoeven
Hi Christoph, On Mon, Apr 9, 2018 at 9:50 AM, Christoph Hellwig wrote: > On Sun, Apr 08, 2018 at 02:45:32PM +1200, Michael Schmitz wrote: >> --- /dev/null >> +++ b/drivers/scsi/zorro_esp.c >> + .driver_data = (unsigned long)&blizzard1230II_data, > > What most (or at least many) drive

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-09 Thread Christoph Hellwig
On Sun, Apr 08, 2018 at 02:45:32PM +1200, Michael Schmitz wrote: > New combined SCSI driver for all ESP based Zorro SCSI boards for > m68k Amiga. > > Code largely based on board specific parts of the old drivers (blz1230.c, > blz2060.c, cyberstorm.c, cyberstormII.c, fastlane.c which were removed >

[PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-07 Thread Michael Schmitz
New combined SCSI driver for all ESP based Zorro SCSI boards for m68k Amiga. Code largely based on board specific parts of the old drivers (blz1230.c, blz2060.c, cyberstorm.c, cyberstormII.c, fastlane.c which were removed after the 2.6 kernel series for lack of maintenance) with contributions by T