Re: [smartmontools-support] [PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-26 Thread Bruce Allen
Dear Linus, Dear Martin, About fifteen years ago, soon after I got interested in SMART and starting working on smartmontools, I wrote some kernel code that added smart data into /sys. (Actually this was around the 2.4 transition so it was under /proc along with lots of other stuff that had nothin

Re: [PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-23 Thread Martin K. Petersen
Linus, > That should be last resort, what the SCSI people want is noble, > and they did a tremendous (impressive) work by hiding all the ATA drives > behind SCSI emulation with libata, so they want me to keep up > that tradition by also making the temperature reading behave > "as if it was a SCS

Re: [PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-23 Thread Martin K. Petersen
Hi Linus, >> The problem with all this is that the storage topology is largely >> undiscoverable for monitoring purposes. We can use heuristics, but in >> many cases there is no reliable way to find out that there is an ATA >> device behind member #3 of a USB-attached RAID controller's virtual d

Re: [PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-23 Thread Guenter Roeck
On 11/23/18 12:18 AM, Linus Walleij wrote: On Thu, Nov 22, 2018 at 9:00 PM Guenter Roeck wrote: Can you possibly extract this as pure hwmon driver outside scsi control ? I'll be happy to accept it as standalone hwmon driver. That should be last resort, what the SCSI people want is noble, and

Re: [PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-23 Thread Linus Walleij
On Thu, Nov 22, 2018 at 9:00 PM Guenter Roeck wrote: > Can you possibly extract this as pure hwmon driver outside scsi control ? > I'll be happy to accept it as standalone hwmon driver. That should be last resort, what the SCSI people want is noble, and they did a tremendous (impressive) work by

Re: [PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-22 Thread Guenter Roeck
[-cc] Hi Linus, On 11/22/18 5:49 AM, Linus Walleij wrote: [ ... ] (It's also worth noting that HDD temperature sensors are notoriously unreliable). I am sorry if you think that D-Link does bad engineering, what I am trying to achieve is upstream support for this device, without any out-of-tre

Re: [PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-22 Thread Linus Walleij
On Wed, Nov 21, 2018 at 6:28 PM Martin K. Petersen wrote: > The problem with all this is that the storage topology is largely > undiscoverable for monitoring purposes. We can use heuristics, but in > many cases there is no reliable way to find out that there is an ATA > device behind member #3 of

Re: [PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-21 Thread Martin K. Petersen
Hi Linus! > This driver does not block any simultaneous use of other SMART > userspace tools, it's a both/and approach, not either/or. The problem with all this is that the storage topology is largely undiscoverable for monitoring purposes. We can use heuristics, but in many cases there is no r

[PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-18 Thread Linus Walleij
S.M.A.R.T. temperature sensors have been supported for years by userspace tools such as smarttools and hddtemp. This adds support to read it from the kernel using the hwmon API and adds a temperature zone for the drive. The idea came about when experimenting with NAS enclosures that lack their own