Re: [PATCH v6 1/3] scsi: ufs: add ioctl interface for query request

2015-03-12 Thread Gilad Broner
>> + if (!buffer) { >> + dev_err(hba->dev, "%s: User buffer is NULL!\n", >> __func__); >> + return -EINVAL; >> + } >> + > > Should we remove this check or move it into ufshcd_query_ioctl()? > For example, BLKFLS ioctl without argument is correct usage, but >

Re: [PATCH v6 1/3] scsi: ufs: add ioctl interface for query request

2015-03-12 Thread Akinobu Mita
2015-03-12 21:27 GMT+09:00 Gilad Broner : > From: Dolev Raviv > > This patch exposes the ioctl interface for UFS driver via SCSI device > ioctl interface. As of now UFS driver would provide the ioctl for query > interface to connected UFS device. > > Signed-off-by: Dolev Raviv > Signed-off-by: No

[PATCH v6 1/3] scsi: ufs: add ioctl interface for query request

2015-03-12 Thread Gilad Broner
From: Dolev Raviv This patch exposes the ioctl interface for UFS driver via SCSI device ioctl interface. As of now UFS driver would provide the ioctl for query interface to connected UFS device. Signed-off-by: Dolev Raviv Signed-off-by: Noa Rubens Signed-off-by: Raviv Shvili Signed-off-by: Ya