Re: [PATCH v5 02/34] cxlflash: Replace magic numbers with literals

2015-10-02 Thread Tomas Henzl
On 1.10.2015 17:54, Matthew R. Ochs wrote: > From: Manoj Kumar > > Magic numbers are not meaningful and can create confusion. As a > remedy, replace them with descriptive literals. > > Replace 512 with literal MAX_SECTOR_UNIT. > Replace 5 with literal CMD_RETRIES. > > Signed-off-by: Matthew R. Och

[PATCH v5 02/34] cxlflash: Replace magic numbers with literals

2015-10-01 Thread Matthew R. Ochs
From: Manoj Kumar Magic numbers are not meaningful and can create confusion. As a remedy, replace them with descriptive literals. Replace 512 with literal MAX_SECTOR_UNIT. Replace 5 with literal CMD_RETRIES. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King