Re: [PATCH v4] SCSI: fix queue cleanup race before scsi_requeue_run_queue is done

2019-08-18 Thread zhengbin (A)
On 2019/8/17 1:09, Bart Van Assche wrote: > On 8/12/19 8:35 PM, zhengbin wrote: >> KASAN reports a use-after-free in 4.19-stable, >> which won't happen after commit 47cdee29ef9d >> ("block: move blk_exit_queue into __blk_release_queue"). > > This patch doesn't apply on top of kernel v4.19.67: > > $

Re: [PATCH v4] SCSI: fix queue cleanup race before scsi_requeue_run_queue is done

2019-08-16 Thread Bart Van Assche
On 8/12/19 8:35 PM, zhengbin wrote: KASAN reports a use-after-free in 4.19-stable, which won't happen after commit 47cdee29ef9d ("block: move blk_exit_queue into __blk_release_queue"). This patch doesn't apply on top of kernel v4.19.67: $ git am ~/\[PATCH\ v4\]\ SCSI\:\ fix\ queue\ cleanup\ ra

Re: [PATCH v4] SCSI: fix queue cleanup race before scsi_requeue_run_queue is done

2019-08-15 Thread zhengbin (A)
On 2019/8/15 23:40, Bart Van Assche wrote: > On 8/14/19 6:50 PM, zhengbin (A) wrote: >> ping > > Sending a "ping" after 46 hours is way too soon and only causes irritation. > What would help though is more information about how this patch has been > tested. Does it e.g. survive the srp tests in

Re: [PATCH v4] SCSI: fix queue cleanup race before scsi_requeue_run_queue is done

2019-08-15 Thread Bart Van Assche
On 8/14/19 6:50 PM, zhengbin (A) wrote: ping Sending a "ping" after 46 hours is way too soon and only causes irritation. What would help though is more information about how this patch has been tested. Does it e.g. survive the srp tests in blktests? Thanks, Bart.

[PATCH v4] SCSI: fix queue cleanup race before scsi_requeue_run_queue is done

2019-08-12 Thread zhengbin
KASAN reports a use-after-free in 4.19-stable, which won't happen after commit 47cdee29ef9d ("block: move blk_exit_queue into __blk_release_queue"). However, backport this patch to 4.19-stable will be a lot of work and the risk is great. Moreover, we should make sure scsi_requeue_run_queue is done