Re: [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.

2016-12-05 Thread Madhani, Himanshu
On 12/5/16, 8:20 AM, "Christoph Hellwig" wrote: >> create mode 100644 drivers/scsi/qla2xxx/qla_bottom.c >> create mode 100644 drivers/scsi/qla2xxx/qla_mq.c >> create mode 100644 drivers/scsi/qla2xxx/qla_top.c > >What's the point of three new fairly small files, two of them very >oddly named?

Re: [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.

2016-12-05 Thread Madhani, Himanshu
On 12/5/16, 12:43 PM, "linux-scsi-ow...@vger.kernel.org on behalf of Madhani, Himanshu" wrote: > >We need to have the spinlock because currently our NPIV implementation does >not utilizes >Q-pair framework. Looks like sent it prematurely. This comment should be read as following We need to

Re: [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.

2016-12-05 Thread Madhani, Himanshu
On 12/4/16, 11:38 PM, "Hannes Reinecke" wrote: >On 12/02/2016 10:44 PM, Himanshu Madhani wrote: >> From: Michael Hernandez >> >> Replaced existing multiple queue functionality with framework >> that allows for the creation of pairs of request and response queues, >> either at start of day or d

Re: [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.

2016-12-05 Thread Christoph Hellwig
> create mode 100644 drivers/scsi/qla2xxx/qla_bottom.c > create mode 100644 drivers/scsi/qla2xxx/qla_mq.c > create mode 100644 drivers/scsi/qla2xxx/qla_top.c What's the point of three new fairly small files, two of them very oddly named? Can't we keep the code together by logical groups? > +

Re: [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.

2016-12-05 Thread Christoph Hellwig
[Hannes, can you please stop the damn full quotes? reading your answers is a major pain] > Have you modified the irq affinity for this? > Typically the irq-affinity changes will treat all vectors identically, > and spread them out across the available CPUS. > But with this layout vector '0' appar

Re: [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.

2016-12-04 Thread Hannes Reinecke
On 12/02/2016 10:44 PM, Himanshu Madhani wrote: > From: Michael Hernandez > > Replaced existing multiple queue functionality with framework > that allows for the creation of pairs of request and response queues, > either at start of day or dynamically. > > Signed-off-by: Sawan Chandak > Signed-

[PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.

2016-12-02 Thread Himanshu Madhani
From: Michael Hernandez Replaced existing multiple queue functionality with framework that allows for the creation of pairs of request and response queues, either at start of day or dynamically. Signed-off-by: Sawan Chandak Signed-off-by: Michael Hernandez Signed-off-by: Himanshu Madhani ---