Re: [PATCH v3 3/6] uas: make work list per-device

2013-09-24 Thread Christoph Hellwig
On Wed, Sep 18, 2013 at 09:33:04AM +0200, Gerd Hoffmann wrote: > > > While being at it rename the list head from "list" to "work", preparing > > > for the addition of a second list. > > > > Why do you even the list? > > The list was already there when I took over maintainance ... > > > What woul

Re: [PATCH v3 3/6] uas: make work list per-device

2013-09-18 Thread Gerd Hoffmann
On Di, 2013-09-17 at 13:30 -0700, Christoph Hellwig wrote: > On Fri, Sep 13, 2013 at 01:27:12PM +0200, Gerd Hoffmann wrote: > > Simplifies locking, we'll protect the list with the device spin lock. > > Also plugs races which can happen when two devices operate on the > > global list. > > > > While

Re: [PATCH v3 3/6] uas: make work list per-device

2013-09-17 Thread Christoph Hellwig
On Fri, Sep 13, 2013 at 01:27:12PM +0200, Gerd Hoffmann wrote: > Simplifies locking, we'll protect the list with the device spin lock. > Also plugs races which can happen when two devices operate on the > global list. > > While being at it rename the list head from "list" to "work", preparing > fo

[PATCH v3 3/6] uas: make work list per-device

2013-09-13 Thread Gerd Hoffmann
Simplifies locking, we'll protect the list with the device spin lock. Also plugs races which can happen when two devices operate on the global list. While being at it rename the list head from "list" to "work", preparing for the addition of a second list. Signed-off-by: Gerd Hoffmann --- driver