Re: [PATCH v3 2/7] scsi: pm: use autosuspend if device supports it

2012-07-26 Thread Oliver Neukum
On Thursday 26 July 2012 20:43:32 Aaron Lu wrote: > > What is the purpose of this approach? > > The purpose is to let scsi layer driver(sd, sr, etc.) use the same pm > api(scsi_autopm_put_device) to put the device to runtime suspended > state. > When the device is ready to be suspended, if it does

Re: [PATCH v3 2/7] scsi: pm: use autosuspend if device supports it

2012-07-26 Thread Aaron Lu
On Thu, Jul 26, 2012 at 12:44:24PM +0200, Oliver Neukum wrote: > On Thursday 26 July 2012 18:05:24 Aaron Lu wrote: > > If the device is using autosuspend, when scsi_autopm_put_device is > > called for it, use autosuspend runtime pm calls instead of the sync > > call. > > What is the purpose of thi

Re: [PATCH v3 2/7] scsi: pm: use autosuspend if device supports it

2012-07-26 Thread Oliver Neukum
On Thursday 26 July 2012 18:05:24 Aaron Lu wrote: > If the device is using autosuspend, when scsi_autopm_put_device is > called for it, use autosuspend runtime pm calls instead of the sync > call. What is the purpose of this approach? You need a very good reason to have an API do two different thi

[PATCH v3 2/7] scsi: pm: use autosuspend if device supports it

2012-07-26 Thread Aaron Lu
If the device is using autosuspend, when scsi_autopm_put_device is called for it, use autosuspend runtime pm calls instead of the sync call. Signed-off-by: Aaron Lu --- drivers/scsi/scsi_pm.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_pm.c b/driv