Re: [PATCH v3 11/11] nvme: Fix a race condition

2016-10-19 Thread Christoph Hellwig
Hi Bart, this looks great! Reviewed-by: Christoph Hellwig Some minor nitpicks below: > void nvme_requeue_req(struct request *req) > { > + blk_mq_requeue_request(req, true); > } > EXPORT_SYMBOL_GPL(nvme_requeue_req); Please just remove the nvme_requeue_req wrapper. > > @@ -2074,11 +

[PATCH v3 11/11] nvme: Fix a race condition

2016-10-18 Thread Bart Van Assche
Avoid that nvme_queue_rq() is still running when nvme_stop_queues() returns. Signed-off-by: Bart Van Assche Cc: Keith Busch Cc: Sagi Grimberg Cc: Christoph Hellwig --- drivers/nvme/host/core.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/nvme/hos