Re: [PATCH v3] use dynamically allocated sense buffer

2008-01-23 Thread Boaz Harrosh
On Mon, Jan 21 2008 at 5:59 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > On Sun, 20 Jan 2008 10:36:56 -0600 > James Bottomley <[EMAIL PROTECTED]> wrote: > >> On Wed, 2008-01-16 at 13:32 +0900, FUJITA Tomonori wrote: >>> This is the third version of: >>> >>> http://marc.info/?l=linux-scsi&m=

Re: [PATCH v3] use dynamically allocated sense buffer

2008-01-21 Thread FUJITA Tomonori
On Sun, 20 Jan 2008 21:37:41 -0700 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Mon, Jan 21, 2008 at 01:08:58PM +0900, FUJITA Tomonori wrote: > > On Sun, 20 Jan 2008 09:40:11 -0700 > > Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > > Longer-term, I want to allow low-level drivers to allocate the

Re: [PATCH v3] use dynamically allocated sense buffer

2008-01-20 Thread Matthew Wilcox
On Mon, Jan 21, 2008 at 01:08:58PM +0900, FUJITA Tomonori wrote: > On Sun, 20 Jan 2008 09:40:11 -0700 > Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > Longer-term, I want to allow low-level drivers to allocate the > > sense_buffer themselves so they can DMA directly into it (ie grown-up dma > > mapp

Re: [PATCH v3] use dynamically allocated sense buffer

2008-01-20 Thread FUJITA Tomonori
On Sun, 20 Jan 2008 09:40:11 -0700 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Wed, Jan 16, 2008 at 01:32:17PM +0900, FUJITA Tomonori wrote: > > This removes static array sense_buffer in scsi_cmnd and uses > > dynamically allocated sense_buffer (with GFP_DMA). > > > > The reason for doing this

Re: [PATCH v3] use dynamically allocated sense buffer

2008-01-20 Thread FUJITA Tomonori
On Sun, 20 Jan 2008 10:36:56 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > On Wed, 2008-01-16 at 13:32 +0900, FUJITA Tomonori wrote: > > This is the third version of: > > > > http://marc.info/?l=linux-scsi&m=120038907123706&w=2 > [...] > > diff --git a/drivers/scsi/scsi.c b/drivers/scsi/s

Re: [PATCH v3] use dynamically allocated sense buffer

2008-01-20 Thread Matthew Wilcox
On Wed, Jan 16, 2008 at 01:32:17PM +0900, FUJITA Tomonori wrote: > This removes static array sense_buffer in scsi_cmnd and uses > dynamically allocated sense_buffer (with GFP_DMA). > > The reason for doing this is that some architectures need cacheline > aligned buffer for DMA: > > http://lkml.or

Re: [PATCH v3] use dynamically allocated sense buffer

2008-01-20 Thread James Bottomley
On Wed, 2008-01-16 at 13:32 +0900, FUJITA Tomonori wrote: > This is the third version of: > > http://marc.info/?l=linux-scsi&m=120038907123706&w=2 [...] > diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c > index 54ff611..0a4a5b8 100644 > --- a/drivers/scsi/scsi.c > +++ b/drivers/scsi/scsi.c

Re: [PATCH v3] use dynamically allocated sense buffer

2008-01-20 Thread Boaz Harrosh
On Wed, Jan 16 2008 at 6:32 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > This is the third version of: > > http://marc.info/?l=linux-scsi&m=120038907123706&w=2 > > The changes from the second version are: > > - Fixed the memory leak bug that Boaz pointed out. > > shots->backup_sense_buff

[PATCH v3] use dynamically allocated sense buffer

2008-01-15 Thread FUJITA Tomonori
This is the third version of: http://marc.info/?l=linux-scsi&m=120038907123706&w=2 The changes from the second version are: - Fixed the memory leak bug that Boaz pointed out. shots->backup_sense_buffer has gone. One sense buffer is allocated per host and it's always attached to the scsi_cmnd li