Re: [PATCH v2.5 3/6] scsi_debug: add multiple queue support

2016-05-05 Thread Bart Van Assche
On 05/05/16 20:47, Douglas Gilbert wrote: On 2016-05-04 06:32 PM, Bart Van Assche wrote: On 04/30/2016 07:44 PM, Douglas Gilbert wrote: +static struct sdebug_queue *get_queue(void) +{ +struct sdebug_queue *sqp = sdebug_q_arr; + +return sqp + (raw_smp_processor_id() % submit_queues); +}

Re: [PATCH v2.5 3/6] scsi_debug: add multiple queue support

2016-05-05 Thread Douglas Gilbert
On 2016-05-04 06:32 PM, Bart Van Assche wrote: On 04/30/2016 07:44 PM, Douglas Gilbert wrote: +static struct sdebug_queue *get_queue(void) +{ +struct sdebug_queue *sqp = sdebug_q_arr; + +return sqp + (raw_smp_processor_id() % submit_queues); +} Does this function have the same purpose

Re: [PATCH v2.5 3/6] scsi_debug: add multiple queue support

2016-05-04 Thread Bart Van Assche
On 04/30/2016 07:44 PM, Douglas Gilbert wrote: +static struct sdebug_queue *get_queue(void) +{ + struct sdebug_queue *sqp = sdebug_q_arr; + + return sqp + (raw_smp_processor_id() % submit_queues); +} Does this function have the same purpose as blk_mq_map_queue()? If so, why has thi

Re: [PATCH v2.5 3/6] scsi_debug: add multiple queue support

2016-05-04 Thread Bart Van Assche
On 05/02/2016 01:35 AM, Hannes Reinecke wrote: On 05/01/2016 04:44 AM, Douglas Gilbert wrote: Add submit_queue parameter (minimum and default: 1; maximum: nr_cpu_ids) that controls how many queues are built, each with their own lock and in_use bit vector. Add statistics parameter which is defaul

Re: [PATCH v2.5 3/6] scsi_debug: add multiple queue support

2016-05-02 Thread Douglas Gilbert
On 2016-05-02 04:35 AM, Hannes Reinecke wrote: On 05/01/2016 04:44 AM, Douglas Gilbert wrote: Add submit_queue parameter (minimum and default: 1; maximum: nr_cpu_ids) that controls how many queues are built, each with their own lock and in_use bit vector. Add statistics parameter which is defaul

Re: [PATCH v2.5 3/6] scsi_debug: add multiple queue support

2016-05-02 Thread Hannes Reinecke
On 05/01/2016 04:44 AM, Douglas Gilbert wrote: > Add submit_queue parameter (minimum and default: 1; maximum: > nr_cpu_ids) that controls how many queues are built, each with > their own lock and in_use bit vector. Add statistics parameter > which is default on. > > Signed-off-by: Douglas Gilbert

[PATCH v2.5 3/6] scsi_debug: add multiple queue support

2016-04-30 Thread Douglas Gilbert
Add submit_queue parameter (minimum and default: 1; maximum: nr_cpu_ids) that controls how many queues are built, each with their own lock and in_use bit vector. Add statistics parameter which is default on. Signed-off-by: Douglas Gilbert --- drivers/scsi/scsi_debug.c | 680 +