Re: [PATCH v2 7/7] [RFC] nvme: Fix a race condition

2016-10-11 Thread Bart Van Assche
On 10/11/16 09:46, Christoph Hellwig wrote: On Wed, Sep 28, 2016 at 05:01:45PM -0700, Bart Van Assche wrote: Avoid that nvme_queue_rq() is still running when nvme_stop_queues() returns. Untested. Signed-off-by: Bart Van Assche Cc: Keith Busch Cc: Christoph Hellwig Cc: Sagi Grimberg --- dri

Re: [PATCH v2 7/7] [RFC] nvme: Fix a race condition

2016-10-11 Thread Christoph Hellwig
On Wed, Sep 28, 2016 at 05:01:45PM -0700, Bart Van Assche wrote: > Avoid that nvme_queue_rq() is still running when nvme_stop_queues() > returns. Untested. > > Signed-off-by: Bart Van Assche > Cc: Keith Busch > Cc: Christoph Hellwig > Cc: Sagi Grimberg > --- > drivers/nvme/host/core.c | 20 ++

Re: [PATCH v2 7/7] [RFC] nvme: Fix a race condition

2016-10-05 Thread Sagi Grimberg
Avoid that nvme_queue_rq() is still running when nvme_stop_queues() returns. Untested. Signed-off-by: Bart Van Assche Cc: Keith Busch Cc: Christoph Hellwig Cc: Sagi Grimberg Bart this looks really good! and possibly fixes an issue I've been chasing with fabrics a while ago. I'll take it f

[PATCH v2 7/7] [RFC] nvme: Fix a race condition

2016-09-28 Thread Bart Van Assche
Avoid that nvme_queue_rq() is still running when nvme_stop_queues() returns. Untested. Signed-off-by: Bart Van Assche Cc: Keith Busch Cc: Christoph Hellwig Cc: Sagi Grimberg --- drivers/nvme/host/core.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/