Re: [PATCH v2 4/5] pm: use callbacks from dev_pm_ops for scsi devices

2012-10-11 Thread Aaron Lu
On Thu, Oct 11, 2012 at 10:57:26AM -0400, Alan Stern wrote: > I have a couple of small changes to suggest. Nothing major. > > On Thu, 11 Oct 2012, Aaron Lu wrote: > > > @@ -102,26 +77,87 @@ static int scsi_bus_prepare(struct device *dev) > > > > static int scsi_bus_suspend(struct device *dev)

Re: [PATCH v2 4/5] pm: use callbacks from dev_pm_ops for scsi devices

2012-10-11 Thread Alan Stern
I have a couple of small changes to suggest. Nothing major. On Thu, 11 Oct 2012, Aaron Lu wrote: > @@ -102,26 +77,87 @@ static int scsi_bus_prepare(struct device *dev) > > static int scsi_bus_suspend(struct device *dev) > { > - return scsi_bus_suspend_common(dev, PMSG_SUSPEND); > + i

[PATCH v2 4/5] pm: use callbacks from dev_pm_ops for scsi devices

2012-10-10 Thread Aaron Lu
Use of pm_message_t is deprecated and device driver is not supposed to use that. This patch tries to migrate the SCSI bus level pm callbacks to call device's pm callbacks defined in its driver's dev_pm_ops. This is achieved by finding out which device pm callback should be used in bus callback fun