Re: [PATCH v2 3/4] ata: add APM X-Gene SoC 6.0Gbps SATA PHY driver

2013-11-20 Thread Loc Ho
Hi, > On Wednesday 20 November 2013, Tejun Heo wrote: >> On Tue, Nov 19, 2013 at 04:53:16PM -0700, Loc Ho wrote: >> > This patch adds support for APM X-Gene SoC 6.0Gbps SATA PHY. This is the >> > physical layer interface for the corresponding SATA host controller. This >> > driver uses the new PHY

Re: [PATCH v2 3/4] ata: add APM X-Gene SoC 6.0Gbps SATA PHY driver

2013-11-20 Thread Loc Ho
Hi, I will move to the official GIT for 3.12.00 instead rc7. It is the same as Linux-next GIT. -Loc On Wed, Nov 20, 2013 at 12:57 AM, Ming Lei wrote: > On Wed, Nov 20, 2013 at 7:53 AM, Loc Ho wrote: >> + >> + sprintf(name, "xgene-ahci-phy-%08X", (u32) ctx->csr_phys); >> + ctx->phy

Re: [PATCH v2 3/4] ata: add APM X-Gene SoC 6.0Gbps SATA PHY driver

2013-11-20 Thread Arnd Bergmann
On Wednesday 20 November 2013, Tejun Heo wrote: > On Wed, Nov 20, 2013 at 10:41 AM, Arnd Bergmann wrote: > > It needs to be in drivers/phy, which is currently being prepared for > > the next merge window and which contains the generic interface used > > in this driver. > > Ah, cool, so I don't n

Re: [PATCH v2 3/4] ata: add APM X-Gene SoC 6.0Gbps SATA PHY driver

2013-11-20 Thread Tejun Heo
Hello, Arnd. On Wed, Nov 20, 2013 at 10:41 AM, Arnd Bergmann wrote: > It needs to be in drivers/phy, which is currently being prepared for > the next merge window and which contains the generic interface used > in this driver. Ah, cool, so I don't need to worry about this one, right? Thanks a l

Re: [PATCH v2 3/4] ata: add APM X-Gene SoC 6.0Gbps SATA PHY driver

2013-11-20 Thread Arnd Bergmann
On Wednesday 20 November 2013, Tejun Heo wrote: > On Tue, Nov 19, 2013 at 04:53:16PM -0700, Loc Ho wrote: > > This patch adds support for APM X-Gene SoC 6.0Gbps SATA PHY. This is the > > physical layer interface for the corresponding SATA host controller. This > > driver uses the new PHY generic fr

Re: [PATCH v2 3/4] ata: add APM X-Gene SoC 6.0Gbps SATA PHY driver

2013-11-20 Thread Tejun Heo
Hey, guys. On Tue, Nov 19, 2013 at 04:53:16PM -0700, Loc Ho wrote: > This patch adds support for APM X-Gene SoC 6.0Gbps SATA PHY. This is the > physical layer interface for the corresponding SATA host controller. This > driver uses the new PHY generic framework posted by Kishon Vijay Abrahm. Hmm.

Re: [PATCH v2 3/4] ata: add APM X-Gene SoC 6.0Gbps SATA PHY driver

2013-11-20 Thread Arnd Bergmann
On Wednesday 20 November 2013 11:37:05 Mark Rutland wrote: > > +static void phy_rd(void *addr, u32 *val) > > +{ > > + *val = readl(addr); > > +#if defined(XGENE_DBG1_CSR) > > + pr_debug("SATAPHY CSR RD: 0x%p value: 0x%08x\n", addr, *val); > > Can you not use dev_dbg here as you do else

Re: [PATCH v2 3/4] ata: add APM X-Gene SoC 6.0Gbps SATA PHY driver

2013-11-20 Thread Mark Rutland
Hi, On Tue, Nov 19, 2013 at 11:53:16PM +, Loc Ho wrote: > This patch adds support for APM X-Gene SoC 6.0Gbps SATA PHY. This is the > physical layer interface for the corresponding SATA host controller. This > driver uses the new PHY generic framework posted by Kishon Vijay Abrahm. > > Signed-

Re: [PATCH v2 3/4] ata: add APM X-Gene SoC 6.0Gbps SATA PHY driver

2013-11-20 Thread Ming Lei
On Wed, Nov 20, 2013 at 7:53 AM, Loc Ho wrote: > + > + sprintf(name, "xgene-ahci-phy-%08X", (u32) ctx->csr_phys); > + ctx->phy = devm_phy_create(ctx->dev, (u32) ctx->csr_phys, > + &xgene_phy_ops, name); The devm_phy_create() API has changed, so suggest