Re: [PATCH v2 20/30] cxlflash: Correct usage of scsi_host_put()

2015-09-22 Thread Matthew R. Ochs
> On Sep 22, 2015, at 3:53 PM, Brian King wrote: > On 09/16/2015 04:30 PM, Matthew R. Ochs wrote: >> Currently, scsi_host_put() is being called prematurely in the >> remove path and is missing entirely in an error cleanup path. >> The former can lead to memory being freed too early with >> subsequ

Re: [PATCH v2 20/30] cxlflash: Correct usage of scsi_host_put()

2015-09-22 Thread Brian King
On 09/16/2015 04:30 PM, Matthew R. Ochs wrote: > Currently, scsi_host_put() is being called prematurely in the > remove path and is missing entirely in an error cleanup path. > The former can lead to memory being freed too early with > subsequent access potentially corrupting data whilst the former

[PATCH v2 20/30] cxlflash: Correct usage of scsi_host_put()

2015-09-16 Thread Matthew R. Ochs
Currently, scsi_host_put() is being called prematurely in the remove path and is missing entirely in an error cleanup path. The former can lead to memory being freed too early with subsequent access potentially corrupting data whilst the former would result in a memory leak. Move the usage on remo

[PATCH v2 20/30] cxlflash: Correct usage of scsi_host_put()

2015-09-16 Thread Matthew R. Ochs
Currently, scsi_host_put() is being called prematurely in the remove path and is missing entirely in an error cleanup path. The former can lead to memory being freed too early with subsequent access potentially corrupting data whilst the former would result in a memory leak. Move the usage on remo