Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-08-11 Thread Luis R. Rodriguez
On Mon, Aug 11, 2014 at 11:27 AM, Takashi Iwai wrote: > Luis R. Rodriguez wrote: >> >> On Sun, Aug 10, 2014 at 08:43:31PM +0800, Greg KH wrote: >> > On Sat, Aug 09, 2014 at 06:41:19PM +0200, Luis R. Rodriguez wrote: >> > > On Wed, Jul 30, 2014 at 03:11:07PM -0700, David Miller wrote: >> > > > From

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-08-11 Thread Takashi Iwai
At Sun, 10 Aug 2014 16:58:02 +0200, Luis R. Rodriguez wrote: > > On Sun, Aug 10, 2014 at 08:43:31PM +0800, Greg KH wrote: > > On Sat, Aug 09, 2014 at 06:41:19PM +0200, Luis R. Rodriguez wrote: > > > On Wed, Jul 30, 2014 at 03:11:07PM -0700, David Miller wrote: > > > > From: "Luis R. Rodriguez" >

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-08-10 Thread Luis R. Rodriguez
On Sun, Aug 10, 2014 at 08:43:31PM +0800, Greg KH wrote: > On Sat, Aug 09, 2014 at 06:41:19PM +0200, Luis R. Rodriguez wrote: > > On Wed, Jul 30, 2014 at 03:11:07PM -0700, David Miller wrote: > > > From: "Luis R. Rodriguez" > > > Date: Mon, 28 Jul 2014 11:28:28 -0700 > > > > > > > Tetsuo bisected

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-08-10 Thread Greg KH
On Sat, Aug 09, 2014 at 06:41:19PM +0200, Luis R. Rodriguez wrote: > On Wed, Jul 30, 2014 at 03:11:07PM -0700, David Miller wrote: > > From: "Luis R. Rodriguez" > > Date: Mon, 28 Jul 2014 11:28:28 -0700 > > > > > Tetsuo bisected and found that commit 786235ee "kthread: make > > > kthread_create()

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-08-09 Thread Luis R. Rodriguez
On Wed, Jul 30, 2014 at 03:11:07PM -0700, David Miller wrote: > From: "Luis R. Rodriguez" > Date: Mon, 28 Jul 2014 11:28:28 -0700 > > > Tetsuo bisected and found that commit 786235ee "kthread: make > > kthread_create() killable" modified kthread_create() to bail as > > soon as SIGKILL is received

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-30 Thread David Miller
From: "Luis R. Rodriguez" Date: Mon, 28 Jul 2014 11:28:28 -0700 > Tetsuo bisected and found that commit 786235ee "kthread: make > kthread_create() killable" modified kthread_create() to bail as > soon as SIGKILL is received. This is causing some issues with > some drivers and at times boot. Josep

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-29 Thread Greg KH
On Wed, Jul 30, 2014 at 02:05:41AM +0200, Luis R. Rodriguez wrote: > On Tue, Jul 29, 2014 at 04:14:22PM -0700, Greg KH wrote: > > On Mon, Jul 28, 2014 at 06:13:43PM -0700, Luis R. Rodriguez wrote: > > > >> > Why not just put the initial "register the device" in a single-shot > > > >> > workqueue or

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-29 Thread Luis R. Rodriguez
On Tue, Jul 29, 2014 at 04:14:22PM -0700, Greg KH wrote: > On Mon, Jul 28, 2014 at 06:13:43PM -0700, Luis R. Rodriguez wrote: > > >> > Why not just put the initial "register the device" in a single-shot > > >> > workqueue or thread or something like that so that modprobe returns > > >> > instantly

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-29 Thread Greg KH
On Mon, Jul 28, 2014 at 06:13:43PM -0700, Luis R. Rodriguez wrote: > >> > Why not just put the initial "register the device" in a single-shot > >> > workqueue or thread or something like that so that modprobe returns > >> > instantly back with a success and all is fine? > >> > >> That surely is pos

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Hannes Reinecke
On 07/29/2014 03:13 AM, Luis R. Rodriguez wrote: On Mon, Jul 28, 2014 at 5:35 PM, Greg KH wrote: On Mon, Jul 28, 2014 at 05:26:34PM -0700, Luis R. Rodriguez wrote: On Mon, Jul 28, 2014 at 4:46 PM, Greg KH wrote: On Mon, Jul 28, 2014 at 12:48:32PM -0700, Luis R. Rodriguez wrote: On Mon, Jul

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Luis R. Rodriguez
On Mon, Jul 28, 2014 at 5:35 PM, Greg KH wrote: > On Mon, Jul 28, 2014 at 05:26:34PM -0700, Luis R. Rodriguez wrote: >> On Mon, Jul 28, 2014 at 4:46 PM, Greg KH wrote: >> > On Mon, Jul 28, 2014 at 12:48:32PM -0700, Luis R. Rodriguez wrote: >> >> On Mon, Jul 28, 2014 at 12:04 PM, Luis R. Rodriguez

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Greg KH
On Mon, Jul 28, 2014 at 05:26:34PM -0700, Luis R. Rodriguez wrote: > On Mon, Jul 28, 2014 at 4:46 PM, Greg KH wrote: > > On Mon, Jul 28, 2014 at 12:48:32PM -0700, Luis R. Rodriguez wrote: > >> On Mon, Jul 28, 2014 at 12:04 PM, Luis R. Rodriguez > >> wrote: > >> > On Mon, Jul 28, 2014 at 11:55 AM,

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Luis R. Rodriguez
On Mon, Jul 28, 2014 at 4:46 PM, Greg KH wrote: > On Mon, Jul 28, 2014 at 12:48:32PM -0700, Luis R. Rodriguez wrote: >> On Mon, Jul 28, 2014 at 12:04 PM, Luis R. Rodriguez >> wrote: >> > On Mon, Jul 28, 2014 at 11:55 AM, Greg KH >> > wrote: >> >> So, what drivers are having problems in their in

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Greg KH
On Mon, Jul 28, 2014 at 12:48:32PM -0700, Luis R. Rodriguez wrote: > On Mon, Jul 28, 2014 at 12:04 PM, Luis R. Rodriguez > wrote: > > On Mon, Jul 28, 2014 at 11:55 AM, Greg KH > > wrote: > >> So, what drivers are having problems in their init sequence, and why > >> aren't they using async firmwa

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Luis R. Rodriguez
On Mon, Jul 28, 2014 at 12:04 PM, Luis R. Rodriguez wrote: > On Mon, Jul 28, 2014 at 11:55 AM, Greg KH wrote: >> So, what drivers are having problems in their init sequence, and why >> aren't they using async firmware loading? > > Fixing drivers is one thing, fixing drivers *now* because *now* >

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Luis R. Rodriguez
On Mon, Jul 28, 2014 at 11:55 AM, Greg KH wrote: > So, what drivers are having problems in their init sequence, and why > aren't they using async firmware loading? Fixing drivers is one thing, fixing drivers *now* because *now* drivers are failing due to a regression is another thing and that's w

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Greg KH
On Mon, Jul 28, 2014 at 11:28:28AM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > Tetsuo bisected and found that commit 786235ee "kthread: make > kthread_create() killable" modified kthread_create() to bail as > soon as SIGKILL is received. This is causing some issues with > some

[PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Tetsuo bisected and found that commit 786235ee "kthread: make kthread_create() killable" modified kthread_create() to bail as soon as SIGKILL is received. This is causing some issues with some drivers and at times boot. Joseph then found that failures occur as the system