Re: [PATCH v2 18/36] mac_scsi: Remove header

2014-10-30 Thread Hannes Reinecke
On 10/27/2014 06:26 AM, Finn Thain wrote: > The #defines in mac_scsi.h are intended to influence subsequent #includes in > mac_scsi.c. IMHO, that's too convoluted. > > Remove mac_scsi.h by moving those macro definitions to mac_scsi.c, > consistent with other NCR5380 drivers. > > Signed-off-by: Fi

[PATCH v2 18/36] mac_scsi: Remove header

2014-10-27 Thread Finn Thain
The #defines in mac_scsi.h are intended to influence subsequent #includes in mac_scsi.c. IMHO, that's too convoluted. Remove mac_scsi.h by moving those macro definitions to mac_scsi.c, consistent with other NCR5380 drivers. Signed-off-by: Finn Thain --- drivers/scsi/mac_scsi.c | 21 +