Re: [PATCH v2 09/11] lpfc: Correct oops on vport port resets

2016-12-20 Thread Hannes Reinecke
On 12/20/2016 05:51 PM, James Smart wrote: On 12/20/2016 5:47 AM, Hannes Reinecke wrote: Now that is what I call a dodgy interface. Casting a 128-bit structure to a 64-bit structure, only to call a memset on the 128-bit structure in lpfc_sli4_iocb2wqe() is positively evil. Can't you clear up

Re: [PATCH v2 09/11] lpfc: Correct oops on vport port resets

2016-12-20 Thread James Smart
On 12/20/2016 5:47 AM, Hannes Reinecke wrote: Now that is what I call a dodgy interface. Casting a 128-bit structure to a 64-bit structure, only to call a memset on the 128-bit structure in lpfc_sli4_iocb2wqe() is positively evil. Can't you clear up this mess by generally passing in a wqe128?

Re: [PATCH v2 09/11] lpfc: Correct oops on vport port resets

2016-12-20 Thread Hannes Reinecke
On 12/20/2016 12:07 AM, James Smart wrote: > > Correct oops on vport port resets. Incorrect WQE type, thus the clearing > code actually overstepped the WQE. > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_sli.c | 7 --- > 1 file changed, 4 insert

[PATCH v2 09/11] lpfc: Correct oops on vport port resets

2016-12-19 Thread James Smart
Correct oops on vport port resets. Incorrect WQE type, thus the clearing code actually overstepped the WQE. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_