Re: [PATCH v2 04/10] qla2xxx: Reset reserved field in firmware options to 0.

2016-12-23 Thread Madhani, Himanshu
On 12/23/16, 12:37 AM, "Bart Van Assche" wrote: >Please use cpu_to_le32() in new code instead of __constant_cpu_to_le32(). >gcc generates the same code for both conversion functions but the former >function makes source code easier to read. Ack. Will update the patch. >

Re: [PATCH v2 04/10] qla2xxx: Reset reserved field in firmware options to 0.

2016-12-23 Thread Bart Van Assche
On Wed, 2016-12-21 at 13:57 -0800, Himanshu Madhani wrote: > During NVRAM initialization in target mode, reset reserved > fields in firmware options to Zero (BIT 15) > > Signed-off-by: Himanshu Madhani > Signed-off-by: Giridhar Malavali > --- > drivers/scsi/qla2xxx/qla_target.c | 17 +++

[PATCH v2 04/10] qla2xxx: Reset reserved field in firmware options to 0.

2016-12-21 Thread Himanshu Madhani
During NVRAM initialization in target mode, reset reserved fields in firmware options to Zero (BIT 15) Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_target.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/dri