Re: [PATCH v2] zfcp: fix reaction on bit error theshold notification with adapter close

2019-10-03 Thread Martin K. Petersen
Steffen, >> Why not just shut FCP down unconditionally on excessive bit errors? >> What's the benefit of allowing things to continue? Are you hoping things >> will eventually recover in a single-path scenario? > > Experience told me that there will be an unforeseen end user scenario > where I ne

Re: [PATCH v2] zfcp: fix reaction on bit error theshold notification with adapter close

2019-10-02 Thread Steffen Maier
On 10/1/19 8:26 PM, Martin K. Petersen wrote: Ok, then why make this a module option that you will have to support for the next 20+ years anyway if you feel this fix is the correct way that it should be done instead? I agree. Why not just shut FCP down unconditionally on excessive bit errors?

Re: [PATCH v2] zfcp: fix reaction on bit error theshold notification with adapter close

2019-10-01 Thread Martin K. Petersen
Greg, > Ok, then why make this a module option that you will have to support > for the next 20+ years anyway if you feel this fix is the correct way > that it should be done instead? I agree. Why not just shut FCP down unconditionally on excessive bit errors? What's the benefit of allowing thi

Re: [PATCH v2] zfcp: fix reaction on bit error theshold notification with adapter close

2019-10-01 Thread Greg KH
On Tue, Oct 01, 2019 at 05:07:50PM +0200, Steffen Maier wrote: > On 10/1/19 4:14 PM, Greg KH wrote: > > On Tue, Oct 01, 2019 at 12:49:49PM +0200, Steffen Maier wrote: > > > On excessive bit errors for the FCP channel ingress fibre path, the > > > channel > > > notifies us. Previously, we only emit

Re: [PATCH v2] zfcp: fix reaction on bit error theshold notification with adapter close

2019-10-01 Thread Steffen Maier
On 10/1/19 4:14 PM, Greg KH wrote: On Tue, Oct 01, 2019 at 12:49:49PM +0200, Steffen Maier wrote: On excessive bit errors for the FCP channel ingress fibre path, the channel notifies us. Previously, we only emitted a kernel message and a trace record. Since performance can become suboptimal with

Re: [PATCH v2] zfcp: fix reaction on bit error theshold notification with adapter close

2019-10-01 Thread Greg KH
On Tue, Oct 01, 2019 at 12:49:49PM +0200, Steffen Maier wrote: > On excessive bit errors for the FCP channel ingress fibre path, the channel > notifies us. Previously, we only emitted a kernel message and a trace record. > Since performance can become suboptimal with I/O timeouts due to > bit error

[PATCH v2] zfcp: fix reaction on bit error theshold notification with adapter close

2019-10-01 Thread Steffen Maier
On excessive bit errors for the FCP channel ingress fibre path, the channel notifies us. Previously, we only emitted a kernel message and a trace record. Since performance can become suboptimal with I/O timeouts due to bit errors, we now stop using an FCP device by default on channel notification s