Re: [PATCH v2] scsi: sd: block: Fix regressions in read-only block device handling

2019-02-22 Thread Christoph Hellwig
On Tue, Feb 12, 2019 at 09:57:17PM -0500, Martin K. Petersen wrote: > Some devices come online in write protected state and switch to > read-write once they are ready to process I/O requests. These devices > broke with commit 20bd1d026aac ("scsi: sd: Keep disk read-only when > re-reading partition"

Re: [PATCH v2] scsi: sd: block: Fix regressions in read-only block device handling

2019-02-19 Thread Martin K. Petersen
Hi Ming, > From the Bugzilla, looks it is only reported on the "Kingston DT > Ultimate G3" USB flash drive. There are several bug reports as a result of the change. It's not at all uncommon for a device to switch at runtime. Before Jeremy's change we just didn't see it because the device settin

Re: [PATCH v2] scsi: sd: block: Fix regressions in read-only block device handling

2019-02-18 Thread Ming Lei
On Wed, Feb 13, 2019 at 5:01 PM Martin K. Petersen wrote: > > Some devices come online in write protected state and switch to > read-write once they are ready to process I/O requests. These devices > broke with commit 20bd1d026aac ("scsi: sd: Keep disk read-only when > re-reading partition") becau

Re: [PATCH v2] scsi: sd: block: Fix regressions in read-only block device handling

2019-02-15 Thread Martin K. Petersen
Christoph? Jens? > Some devices come online in write protected state and switch to > read-write once they are ready to process I/O requests. These devices > broke with commit 20bd1d026aac ("scsi: sd: Keep disk read-only when > re-reading partition") because we had no way to distinguish between a

Re: [PATCH v2] scsi: sd: block: Fix regressions in read-only block device handling

2019-02-12 Thread Hannes Reinecke
On 2/13/19 3:57 AM, Martin K. Petersen wrote: Some devices come online in write protected state and switch to read-write once they are ready to process I/O requests. These devices broke with commit 20bd1d026aac ("scsi: sd: Keep disk read-only when re-reading partition") because we had no way to d

[PATCH v2] scsi: sd: block: Fix regressions in read-only block device handling

2019-02-12 Thread Martin K. Petersen
Some devices come online in write protected state and switch to read-write once they are ready to process I/O requests. These devices broke with commit 20bd1d026aac ("scsi: sd: Keep disk read-only when re-reading partition") because we had no way to distinguish between a user decision to set a bloc